-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tau decay-mode to genTauJets as status #41092
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41092/34706
|
A new Pull Request was created by @mbluj for master. It involves the following packages:
@cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1bee7/31392/summary.html Comparison SummarySummary:
|
+1 |
merge |
Should this PR and #41064 be backported to 13_0_X? |
In principle yes, modulo the fact that the original error was not actually fixed by them, see #41064 (comment) |
Yes, I saw the comment. I will try to reproduce and understand the error, but I am afraid it has something to do with the |
PR description:
This PR adds a decay-mode of a genTau to a genTauJet built for the genTau as a status of the genTauJet. The decay-mode is as returned by
PhysicsTools/JetMCUtils/src/JetMCTag.cc
with value converted to an integer as defined in the enum inDataFormats/TauReco/interface/PFTau.h
(Tau POG standard). In case of an undecayed genTau the status is negative and can be used to filter out corresponding genTauJet.The
PhysicsTools/JetMCUtils/src/JetMCTag.cc
tool was modified to deal correctly with genTauJets for undecayed genTaus where the genTau is its unique constituent. Namely, in this case the "tau" decay-mode is returned.This PR is a followup for #41064 and implements promise from #41064 (comment).
PR validation:
PR tested successfully with wf 10024.0 ("TTbar_13+2017")