Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tau decay-mode to genTauJets as status #41092

Merged
merged 1 commit into from
Mar 19, 2023

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Mar 17, 2023

PR description:

This PR adds a decay-mode of a genTau to a genTauJet built for the genTau as a status of the genTauJet. The decay-mode is as returned by PhysicsTools/JetMCUtils/src/JetMCTag.cc with value converted to an integer as defined in the enum in DataFormats/TauReco/interface/PFTau.h (Tau POG standard). In case of an undecayed genTau the status is negative and can be used to filter out corresponding genTauJet.
The PhysicsTools/JetMCUtils/src/JetMCTag.cc tool was modified to deal correctly with genTauJets for undecayed genTaus where the genTau is its unique constituent. Namely, in this case the "tau" decay-mode is returned.
This PR is a followup for #41064 and implements promise from #41064 (comment).

PR validation:

PR tested successfully with wf 10024.0 ("TTbar_13+2017")

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41092/34706

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mbluj for master.

It involves the following packages:

  • PhysicsTools/JetMCAlgos (analysis)
  • PhysicsTools/JetMCUtils (analysis)

@cmsbuild can you please review it and eventually sign? Thanks.
@AlexDeMoor, @emilbols, @AnnikaStein, @JyothsnaKomaragiri, @andrzejnovak, @demuller this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1bee7/31392/summary.html
COMMIT: f0c07b1
CMSSW: CMSSW_13_1_X_2023-03-17-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41092/31392/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 7 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3550882
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3550860
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

+1

@perrotta
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 6db3226 into cms-sw:master Mar 19, 2023
@mbluj
Copy link
Contributor Author

mbluj commented Mar 20, 2023

Should this PR and #41064 be backported to 13_0_X?

@perrotta
Copy link
Contributor

Should this PR and #41064 be backported to 13_0_X?

In principle yes, modulo the fact that the original error was not actually fixed by them, see #41064 (comment)

@mbluj
Copy link
Contributor Author

mbluj commented Mar 20, 2023

Should this PR and #41064 be backported to 13_0_X?

In principle yes, modulo the fact that the original error was not actually fixed by them, see #41064 (comment)

Yes, I saw the comment. I will try to reproduce and understand the error, but I am afraid it has something to do with the MBUEandQCDValidation module rather than with Tau POG stuff. I meantime I will backport this PR to 13_0_X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants