-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have ExternalGeneratorFilter throw an generator specific exception [13_0] #41085
Have ExternalGeneratorFilter throw an generator specific exception [13_0] #41085
Conversation
Looking at log files from failed jobs showed that the external failures at event time where all caused by the generators being run in the external process. Throwing a generator specific exception will cause cmsRun to exit with a specific code which will help evaluate failures in the production system.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_13_0_X. It involves the following packages:
@SiewYan, @mkirsano, @Saptaparna, @cmsbuild, @alberto-sanchez, @menglu21, @GurpreetSinghChahal can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35c86b/31374/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
backport of #41073 |
+1 |
PR description:
Looking at log files from failed jobs showed that the external failures at event time where all caused by the generators being run in the external process. Throwing a generator specific exception will cause cmsRun to exit with a specific code which will help evaluate failures in the production system.
PR validation:
Code compiles
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #41073