Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run tests in separate tests #41055

Closed
wants to merge 1 commit into from
Closed

Conversation

smuzaffar
Copy link
Contributor

This is a quick fix for unittests failing in IBs. Both tests generate same output files name [a] which also conflict with out directory generated by another test. For now I propose to run these tests in their own separate directory. Once we enable USE_UNITTEST_DIR for cmssw then these changes can be reverted.

[a]

Singularity> ls *
CalibCalorimetryEcalLaserSortingRunStreamer:
alt  corrupt  ext  gennums.txt  in  inDir  myout.root  out  outAlt  outExt  process  processed  teststreamfile.original  watcherSourceToken

DQMServicesStreamerIORunStreamer:
alt  ext  gennums.txt  in  myout.root  out  outAlt  outExt  run000001

@smuzaffar
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41055/34636

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

  • CalibCalorimetry/EcalLaserSorting (alca)
  • DQMServices/StreamerIO (dqm)

@pmandrik, @emanueleusai, @tvami, @saumyaphor4252, @syuvivida, @rvenditti, @micsucmed, @francescobrivio can you please review it and eventually sign? Thanks.
@barvic, @rchatter, @tocheng, @argiro, @thomreis, @simonepigazzini, @mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a53bc2/31280/summary.html
COMMIT: 0c70d02
CMSSW: CMSSW_13_1_X_2023-03-14-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41055/31280/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3550756
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3550728
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

@perrotta @rappoccio, as this is just a technical change so can we get this in 11h00 IB?

@tvami
Copy link
Contributor

tvami commented Mar 15, 2023

+alca

@smuzaffar
Copy link
Contributor Author

I have merged cms-sw/cmsdist#8385 ( to enable all unit tests to use separate test dir) so this PR is not needed any more. Once new IB based on cms-sw/cmsdist#8385 is available then I will clode the PR

@smuzaffar
Copy link
Contributor Author

IB based on cms-sw/cmsdist#8383 is available and unit tests passed. So this PR is not needed any more

@smuzaffar smuzaffar closed this Mar 16, 2023
@smuzaffar smuzaffar deleted the unit-test-fix1 branch March 16, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants