Phase2-hgx336C Try to introduce the guard rings for both full and partial wafers of HGCal (will be a part of V18) #41048

bsunanda · 2023-03-14T07:46:27Z

PR description:

Try to introduce the guard rings for both full and partial wafers of HGCal (will be a part of V18).

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

…HGCal (will be a part of V18)

cmsbuild · 2023-03-14T07:56:09Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41048/34614

This PR adds an extra 56KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41048/34614/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41048/34614/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2023-03-14T08:03:12Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41048/34616

This PR adds an extra 56KB to repository

cmsbuild · 2023-03-14T08:03:43Z

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Geometry/ForwardCommonData (geometry)
Geometry/HGCalCommonData (geometry, upgrade)
SimG4CMS/Calo (simulation)

@civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@felicepantaleo, @rovere, @thomreis, @simonepigazzini, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

bsunanda · 2023-03-14T08:17:18Z

@cmsbuild Please test

cmsbuild · 2023-03-14T11:41:16Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41048/34619

This PR adds an extra 56KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41048/34619/code-format.patch
e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41048/34619/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

cmsbuild · 2023-03-14T18:18:27Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c34ee/31266/summary.html
COMMIT: 8972bf5
CMSSW: CMSSW_13_1_X_2023-03-13-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41048/31266/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 13 lines to the logs
Reco comparison results: 15545 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3550756
DQMHistoTests: Total failures: 19287
DQMHistoTests: Total nulls: 241
DQMHistoTests: Total successes: 3531206
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: found differences in 4 / 47 workflows

civanch · 2023-03-15T08:18:32Z

+1

geometry is changed, so Phase-2 WFs are affected.

srimanob · 2023-03-16T05:45:19Z

To confirm from the PR description, when you said it will be part of V18. But the PR touches v16, v17 by adding UseOffset which should not make the change in physics, but SIM history. So that why we see the difference in D88 in PR test.

Do I understand correctly?

bsunanda · 2023-03-23T08:29:03Z

@srimanob Yes it changes SIM history only and that is why we see some difference

srimanob · 2023-03-23T09:02:55Z

+Upgrade

cmsbuild · 2023-03-23T09:03:26Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2023-03-23T09:26:26Z

+1

perrotta

I missed this one: I think this should be re-commented out, if we don't want to flood the outputs with these log messages. Could you please confirm, Sunanda?

perrotta · 2023-03-23T09:15:41Z

Geometry/HGCalCommonData/src/HGCalParametersFromDD.cc

@@ -8,7 +8,7 @@
 #include "Geometry/HGCalCommonData/interface/HGCalGeometryMode.h"
 #include "Geometry/HGCalCommonData/interface/HGCalParameters.h"

-//#define EDM_ML_DEBUG
+#define EDM_ML_DEBUG


Should this get re-commented out?

perrotta · 2023-03-24T11:03:14Z

Ping @bsunanda

makortel · 2023-03-27T18:54:15Z

Geometry/HGCalCommonData/src/HGCalWaferMask.cc

-                    {20, 14, 3, 4, 20}};
+    int np[6][5] = {{45, 39, 4, 5, 45},
+                    {47, 40, 5, 0, 47},
+                    {48, 41, 0, 1, 48},


Just to note here as well, seems that this PR is causing segfaults in CLANG IBs (see #41176), and ASAN and UBSAN warnings (see #41184).

Try to introduce the gurad rings for both full and partial wafers of …

4ab1a92

…HGCal (will be a part of V18)

cmsbuild added this to the CMSSW_13_1_X milestone Mar 14, 2023

cmsbuild added simulation-pending geometry-pending pending-signatures tests-pending orp-pending upgrade-pending code-checks-pending labels Mar 14, 2023

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 14, 2023

Code check

343912e

cmsbuild added code-checks-pending and removed code-checks-rejected labels Mar 14, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 14, 2023

cmsbuild added tests-started and removed tests-pending labels Mar 14, 2023

Update from Pruthvi

577d690

cmsbuild added tests-pending code-checks-pending and removed tests-started code-checks-approved labels Mar 14, 2023

cmsbuild added code-checks-rejected and removed code-checks-pending labels Mar 14, 2023

cmsbuild added the tests-started label Mar 14, 2023

cmsbuild added tests-approved and removed tests-started labels Mar 14, 2023

cmsbuild added geometry-approved simulation-approved and removed simulation-pending geometry-pending labels Mar 15, 2023

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Mar 23, 2023

cmsbuild added orp-approved and removed orp-pending labels Mar 23, 2023

cmsbuild merged commit 97005a9 into cms-sw:master Mar 23, 2023

perrotta reviewed Mar 23, 2023

View reviewed changes

This was referenced Mar 23, 2023

Update onnxruntime to 1.14.1 cms-sw/cmsdist#8397

Merged

Integration of extended ParticleNet trainings for simultaneous jet flavor tagging, pT regression, and tau ID + reconstruction #40745

Merged

smuzaffar mentioned this pull request Mar 24, 2023

Fix build failure in DBG_X #41169

Merged

perrotta mentioned this pull request Mar 27, 2023

Run3-gex157B Replace use of cout's with LogVerbatim in Geometry/DTGeo metry and Geometry/DTGeometryBuilder #41174

Merged

makortel mentioned this pull request Mar 27, 2023

[CLANG_X] SIGSEGV in vecgeom::cxx::ExtrudedStruct::CreateTessellated RelVal 20034.0 #41176

Closed

makortel reviewed Mar 27, 2023

View reviewed changes

perrotta mentioned this pull request Mar 28, 2023

Phase2-hgx336E Try to fix an error in the code for HGCal V16 Geometry and take care of the #define statement in Geometry/HGCalCommonData/src #41208

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Phase2-hgx336C Try to introduce the guard rings for both full and partial wafers of HGCal (will be a part of V18) #41048

Phase2-hgx336C Try to introduce the guard rings for both full and partial wafers of HGCal (will be a part of V18) #41048

bsunanda commented Mar 14, 2023

cmsbuild commented Mar 14, 2023

cmsbuild commented Mar 14, 2023

cmsbuild commented Mar 14, 2023

bsunanda commented Mar 14, 2023

cmsbuild commented Mar 14, 2023

cmsbuild commented Mar 14, 2023

civanch commented Mar 15, 2023

srimanob commented Mar 16, 2023

bsunanda commented Mar 23, 2023

srimanob commented Mar 23, 2023

cmsbuild commented Mar 23, 2023

perrotta commented Mar 23, 2023

perrotta left a comment

perrotta Mar 23, 2023

perrotta commented Mar 24, 2023

makortel Mar 27, 2023

Phase2-hgx336C Try to introduce the guard rings for both full and partial wafers of HGCal (will be a part of V18) #41048

Phase2-hgx336C Try to introduce the guard rings for both full and partial wafers of HGCal (will be a part of V18) #41048

Conversation

bsunanda commented Mar 14, 2023

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Mar 14, 2023

cmsbuild commented Mar 14, 2023

cmsbuild commented Mar 14, 2023

bsunanda commented Mar 14, 2023

cmsbuild commented Mar 14, 2023

cmsbuild commented Mar 14, 2023

Comparison Summary

civanch commented Mar 15, 2023

srimanob commented Mar 16, 2023

bsunanda commented Mar 23, 2023

srimanob commented Mar 23, 2023

cmsbuild commented Mar 23, 2023

perrotta commented Mar 23, 2023

perrotta left a comment

Choose a reason for hiding this comment

perrotta Mar 23, 2023

Choose a reason for hiding this comment

perrotta commented Mar 24, 2023

makortel Mar 27, 2023

Choose a reason for hiding this comment