Removing not used muon MVAs from miniAOD (backport) #41043

andrea21z · 2023-03-13T17:03:19Z

PR description:

This PR is created to solved an issue involving two Muon MVAs (ttH lepton MVAs). This removal is a follow up on the discussion taken in PR40100.
We want to remove the 'mvaValue' and 'lowptMvaValue' from miniAOD because those MVAs are not updated and they are not used by anyone. The analyses using these MVAs use nanoAOD, and there the MVAs are correct.
When I was doing it, I found that inside the loop where the MVAs values were computed, it was also filled the selector 'MultiIsoMedium' and the variables 'jetPtRel' and 'jetPtRatio'. I talked to SUSY group to see if they were variables that were currently in use and, after checking with analyzers, they told me to leave them in the code. In short, I deleted the MVAs and everything related to them and renamed the module 'MuonMvaEstimator' to 'CalculatePtRatioRel'.

PR validation:

We check the output running runTheMatrix and everything looks fine.
We execute the basic tests suggested in the CMSSW PR instructions.

This PR is a backport of PR#40876.

cmsbuild · 2023-03-13T17:03:48Z

A new Pull Request was created by @andrea21z for CMSSW_13_0_X.

It involves the following packages:

DataFormats/PatCandidates (xpog, reconstruction)
PhysicsTools/NanoAOD (xpog)
PhysicsTools/PatAlgos (xpog, reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @mbluj, @demuller, @seemasharmafnal, @mmarionncern, @missirol, @ahinzmann, @jdolen, @azotz, @rovere, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @AlexDeMoor, @AnnikaStein, @JyothsnaKomaragiri, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

Backported from Removing not used muon MVAs from miniAOD #40876

swertz · 2023-03-14T14:34:12Z

enable nano

swertz · 2023-03-14T14:34:18Z

please test

cmsbuild · 2023-03-14T17:40:11Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-786924/31269/summary.html
COMMIT: b765fc7
CMSSW: CMSSW_13_0_X_2023-03-14-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41043/31269/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 26 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 135 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3550998
DQMHistoTests: Total failures: 9
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3550967
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -2.9879999999999995 KiB( 48 files compared)
DQMHistoSizes: changed ( 11634.0,... ): -0.360 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 13234.0,... ): -0.234 KiB Physics/NanoAODDQM
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially removed 10 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 20 differences found in the comparisons
DQMHistoTests: Total files compared: 11
DQMHistoTests: Total histograms compared: 10777
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 10777
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -3.0959999999999996 KiB( 10 files compared)
DQMHistoSizes: changed ( 2500.311,... ): -0.360 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 2500.331,... ): -0.234 KiB Physics/NanoAODDQM
Checked 23 log files, 10 edm output root files, 11 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.31	2.223	2.224	-0.001 ( -0.1% )	9.58	9.54	+0.5%	1.454	1.518
2500.311	2.323	2.323	-0.001 ( -0.0% )	9.26	9.13	+1.4%	1.825	1.893
2500.312	2.275	2.277	-0.002 ( -0.1% )	9.42	9.33	+1.0%	1.815	1.882
2500.33	1.098	1.099	-0.002 ( -0.2% )	22.34	21.31	+4.8%	1.638	1.631
2500.331	1.392	1.394	-0.001 ( -0.1% )	16.21	15.78	+2.7%	1.788	1.786
2500.332	1.324	1.326	-0.002 ( -0.2% )	18.14	17.87	+1.5%	1.830	1.825
2500.401	2.137	2.139	-0.001 ( -0.1% )	10.39	10.50	-1.0%	1.152	1.213
2500.501	1.710	1.711	-0.001 ( -0.1% )	16.85	16.72	+0.8%	1.069	1.146
2500.511	1.122	1.124	-0.002 ( -0.2% )	31.22	31.01	+0.7%	1.319	1.383
2500.601	2.049	2.050	-0.001 ( -0.1% )	12.59	12.67	-0.6%	1.128	1.196

swertz · 2023-03-15T09:45:20Z

+1

Backport in line with master.

clacaputo · 2023-03-21T13:53:05Z

+reconstruction

backport of Removing not used muon MVAs from miniAOD #40876
in line with master

cmsbuild · 2023-03-21T13:53:34Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2023-03-21T14:35:33Z

backport of #40876

cmsbuild · 2023-03-22T11:10:14Z

Pull request #41043 was updated. @swertz, @vlimant, @clacaputo, @cmsbuild, @simonepigazzini, @mandrenguyen can you please check and sign again.

cmsbuild · 2023-03-22T11:46:48Z

Pull request #41043 was updated. @swertz, @vlimant, @clacaputo, @cmsbuild, @simonepigazzini, @mandrenguyen can you please check and sign again.

clacaputo · 2023-03-27T09:43:25Z

please test

cmsbuild · 2023-03-27T13:39:47Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-786924/31610/summary.html
COMMIT: e4ef45e
CMSSW: CMSSW_13_0_X_2023-03-26-2300/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41043/31610/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 4 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 128 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3554479
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3554451
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -2.9879999999999995 KiB( 48 files compared)
DQMHistoSizes: changed ( 11634.0,... ): -0.360 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 13234.0,... ): -0.234 KiB Physics/NanoAODDQM
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially removed 4 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 20 differences found in the comparisons
DQMHistoTests: Total files compared: 11
DQMHistoTests: Total histograms compared: 10777
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 10777
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -3.0959999999999996 KiB( 10 files compared)
DQMHistoSizes: changed ( 2500.311,... ): -0.360 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 2500.331,... ): -0.234 KiB Physics/NanoAODDQM
Checked 23 log files, 10 edm output root files, 11 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.31	2.223	2.224	-0.001 ( -0.1% )	9.71	9.81	-1.0%	1.492	1.577
2500.311	2.322	2.323	-0.001 ( -0.0% )	9.24	9.42	-2.0%	1.865	1.953
2500.312	2.275	2.277	-0.002 ( -0.1% )	9.43	9.52	-0.9%	1.856	1.962
2500.33	1.098	1.099	-0.002 ( -0.2% )	21.75	21.84	-0.4%	1.620	1.693
2500.331	1.392	1.394	-0.001 ( -0.1% )	16.05	16.14	-0.6%	1.779	1.848
2500.332	1.324	1.326	-0.002 ( -0.2% )	18.22	18.28	-0.3%	1.815	1.796
2500.401	2.137	2.138	-0.002 ( -0.1% )	10.60	10.56	+0.3%	1.185	1.266
2500.501	1.710	1.711	-0.001 ( -0.1% )	16.08	16.65	-3.4%	1.097	1.177
2500.511	1.122	1.124	-0.002 ( -0.2% )	31.38	30.30	+3.6%	1.330	1.444
2500.601	2.049	2.050	-0.001 ( -0.1% )	12.60	12.49	+0.9%	1.168	1.257

clacaputo · 2023-03-27T14:20:51Z

+reconstruction

resign
backport of Removing not used muon MVAs from miniAOD #40876
in line with master

swertz · 2023-03-27T14:21:49Z

+1

cmsbuild · 2023-03-27T14:22:16Z

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2023-03-28T06:29:10Z

+1

Verbatim backport of Removing not used muon MVAs from miniAOD #40876

removing non-used muon MVAs

b765fc7

cmsbuild added this to the CMSSW_13_0_X milestone Mar 13, 2023

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending xpog-pending labels Mar 13, 2023

andrea21z mentioned this pull request Mar 14, 2023

Removing not used muon MVAs from miniAOD #40876

Merged

cmsbuild added tests-started and removed tests-pending labels Mar 14, 2023

cmsbuild added tests-approved and removed tests-started labels Mar 14, 2023

cmsbuild added xpog-approved and removed xpog-pending labels Mar 15, 2023

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Mar 21, 2023

cmsbuild added the backport label Mar 21, 2023

implementing A. Perrota comments

5f24cbe

cmsbuild removed reconstruction-approved fully-signed labels Mar 22, 2023

cmsbuild added reconstruction-pending pending-signatures tests-pending xpog-pending and removed tests-approved xpog-approved labels Mar 22, 2023

updating mvaDRMax * mvaDRMax

e4ef45e

cmsbuild added tests-started backport-ok and removed tests-pending backport labels Mar 27, 2023

cmsbuild added tests-approved and removed tests-started labels Mar 27, 2023

cmsbuild added reconstruction-approved fully-signed xpog-approved and removed reconstruction-pending pending-signatures xpog-pending labels Mar 27, 2023

cmsbuild added orp-approved and removed orp-pending labels Mar 28, 2023

cmsbuild merged commit fd56960 into cms-sw:CMSSW_13_0_X Mar 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removing not used muon MVAs from miniAOD (backport) #41043

Removing not used muon MVAs from miniAOD (backport) #41043

andrea21z commented Mar 13, 2023

cmsbuild commented Mar 13, 2023 •

edited

Loading

swertz commented Mar 14, 2023

swertz commented Mar 14, 2023

cmsbuild commented Mar 14, 2023

swertz commented Mar 15, 2023

clacaputo commented Mar 21, 2023

cmsbuild commented Mar 21, 2023

perrotta commented Mar 21, 2023 •

edited

Loading

cmsbuild commented Mar 22, 2023

cmsbuild commented Mar 22, 2023

clacaputo commented Mar 27, 2023

cmsbuild commented Mar 27, 2023

clacaputo commented Mar 27, 2023

swertz commented Mar 27, 2023

cmsbuild commented Mar 27, 2023

perrotta commented Mar 28, 2023

Removing not used muon MVAs from miniAOD (backport) #41043

Removing not used muon MVAs from miniAOD (backport) #41043

Conversation

andrea21z commented Mar 13, 2023

PR description:

PR validation:

This PR is a backport of PR#40876.

cmsbuild commented Mar 13, 2023 • edited Loading

swertz commented Mar 14, 2023

swertz commented Mar 14, 2023

cmsbuild commented Mar 14, 2023

Comparison Summary

NANO Comparison Summary

swertz commented Mar 15, 2023

clacaputo commented Mar 21, 2023

cmsbuild commented Mar 21, 2023

perrotta commented Mar 21, 2023 • edited Loading

cmsbuild commented Mar 22, 2023

cmsbuild commented Mar 22, 2023

clacaputo commented Mar 27, 2023

cmsbuild commented Mar 27, 2023

Comparison Summary

NANO Comparison Summary

clacaputo commented Mar 27, 2023

swertz commented Mar 27, 2023

cmsbuild commented Mar 27, 2023

perrotta commented Mar 28, 2023

cmsbuild commented Mar 13, 2023 •

edited

Loading

perrotta commented Mar 21, 2023 •

edited

Loading