Phase2 Tracker Digitizer updated to have the possibility to used planer pixel algorithm in 3D pixel

[suchandradutta]

PR description:

Update to include the possibility to use planer-pixel digitization algorithm (PixelDigitizerAlgorithm) for 3D-pixel modules. A configuration parameter usePseudoPixel3DAlgo is introduced to activate/dis-activate this possibility.

• what changes are expected in the output if any : None
• what other PRs or externals it depends upon if any : None

PR validation:

Used FourMuon events (runTheMatrix option 20800.0) and compared the histograms

@emiglior @tvami @duartej

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41010/34531

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimTracker/SiPhase2Digitizer/plugins/Phase2TrackerDigitizer.cc modified in PR(s): [Draft] Add fillDescriptions to SiPixel digitizers  #40673
  • File SimTracker/SiPhase2Digitizer/plugins/Phase2TrackerDigitizer.h modified in PR(s): [Draft] Add fillDescriptions to SiPixel digitizers  #40673

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41010/34531/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41010/34531/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[tvami]

Thanks @suchandradutta , please do the code-checks as well

[suchandradutta]

@tvami I did both code-checks and code-format before doing the 'push' . I have tried to do that again now but there is no further update. You can see there are two commits :

• e411402
• 118498a

Looking at the patch it looks like the code-checks was performed on the first commit.

I do not understand why the second commit is not considered

[mmusich]

code-checks

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41010/34543

• This PR adds an extra 28KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File SimTracker/SiPhase2Digitizer/plugins/Phase2TrackerDigitizer.cc modified in PR(s): [Draft] Add fillDescriptions to SiPixel digitizers  #40673
  • File SimTracker/SiPhase2Digitizer/plugins/Phase2TrackerDigitizer.h modified in PR(s): [Draft] Add fillDescriptions to SiPixel digitizers  #40673

[cmsbuild]

A new Pull Request was created by @suchandradutta (Suchandra Dutta) for master.

It involves the following packages:

• SimTracker/SiPhase2Digitizer (upgrade, simulation)

@cmsbuild, @AdrianoDee, @srimanob, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@VourMa, @mtosi, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @missirol, @mmusich, @threus, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@suchandradutta

I do not understand why the second commit is not considered

It looks like your second commit predates the timestamp of the first code-checks, which is why the bot did not re-run it.
Now all is cleared up and we can run tests.

[mmusich]

@cmsbuild, please test

[suchandradutta]

@suchandradutta

I do not understand why the second commit is not considered

It looks like your second commit predates the timestamp of the first code-checks, which is why the bot did not re-run it. Now all is cleared up and we can run tests.

I do not know either! I created the PR after the 2nd commit.

[mmusich]

I created the PR after the 2nd commit.

gitHub history shows something different

might have been a glitch in the web-service, anyhow it's not really important at this point.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38f54c/31183/summary.html
COMMIT: 118498a
CMSSW: CMSSW_13_1_X_2023-03-09-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41010/31183/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 2 lines from the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3530381
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3530356
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mmusich]

test parameters

• workflow = 20800.0
• relvals_opt= -w upgrade

[tvami]

@cmsbuild , please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-38f54c/31199/summary.html
COMMIT: 118498a
CMSSW: CMSSW_13_1_X_2023-03-10-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41010/31199/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

• You potentially removed 18 lines from the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3624724
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3624699
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 218 log files, 168 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1