Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13_0 backport]: 2023 FastSim Workflow #41006

Merged
merged 2 commits into from
Mar 21, 2023
Merged

[13_0 backport]: 2023 FastSim Workflow #41006

merged 2 commits into from
Mar 21, 2023

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Mar 9, 2023

PR description:

Backport of #40954

PR validation:

Test with workflow 14034.0.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport PR.

@cmsbuild cmsbuild added this to the CMSSW_13_0_X milestone Mar 9, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2023 •
edited
Loading

A new Pull Request was created by @srimanob (Phat Srimanobhas) for CMSSW_13_0_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

srimanob commented Mar 9, 2023

test parameters:

  • workflows = 14034.0
  • relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,identity,ged,machine,premix,nano,gpu,2017,2026

@srimanob
Copy link
Contributor Author

srimanob commented Mar 9, 2023

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32545a/31157/summary.html
COMMIT: a2940a7
CMSSW: CMSSW_13_0_X_2023-03-08-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41006/31157/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 16 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3557934
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3557909
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

missirol
missirol reviewed Mar 10, 2023
View reviewed changes
Copy link
Contributor

@missirol missirol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is in a bit of a clash with #41017.

Once one of the two is merged, the other one will need to be rebased.

Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py Outdated
Comment on lines 2321 to 2322
'GT' : 'auto:phase1_2023_realistic',
'HLTmenu': '@relval2022',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should eventually change to HLT:@relval2023 in light of #41017 (and #41007). If this PR is integrated before those, #41017 will need to be rebased to change this to @relval2023.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @missirol
I will let #41017 and #41007 merge first. This PR can be rebases, it is very small.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @srimanob ! Could you please also have a look at #41016 (needs upgrade signature) ?

@srimanob
Copy link
Contributor Author

hold

Waiting #41017 and #41007 to be merged first.

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @srimanob
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Mar 10, 2023
@srimanob
Copy link
Contributor Author

unhold

@cmsbuild cmsbuild removed the hold label Mar 18, 2023
@cmsbuild
Copy link
Contributor

Pull request #41006 was updated. @bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please check and sign again.

@srimanob
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-32545a/31399/summary.html
COMMIT: 2f99cc4
CMSSW: CMSSW_13_0_X_2023-03-18-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41006/31399/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 14 lines from the logs
  • Reco comparison results: 16 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3551048
  • DQMHistoTests: Total failures: 893
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3550133
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor Author

srimanob commented Mar 18, 2023 •
edited
Loading

+Upgrade

The 2023 FastSim workflow (14034.0_TTbar_14TeV+2023FS) runs fine. The failure in comparison is on 11634.7_TTbar_14TeV+2021_trackingMkFit/ which should not relate to this PR.

@kskovpen
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

backport of #40954

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9ed85f7 into cms-sw:CMSSW_13_0_X Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@missirol missirol missirol left review comments

Assignees
No one assigned
Labels
backport-ok fully-signed orp-approved pdmv-approved tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_13_0_X
Development

Successfully merging this pull request may close these issues.
5 participants
@srimanob @cmsbuild @kskovpen @perrotta @missirol