Update L1 menu tag for data RelVals and 2023/2024, Phase2 MC GTs #41005

saumyaphor4252 · 2023-03-09T09:10:52Z

PR description:

This PR updates the Run3 2023/2024 and Phase2 MC GTs with the latest L1 Menu tag, i.e. L1Menu_Collisions2023_v1_0_0_xml as requested in this CMSTalk post [1].

In addition, it also updates the Run3 RelVal GTs.

FYI @missirol @elfontan

[1] https://cms-talk.web.cern.ch/t/run-3-gt-update-of-the-2023-l1-menu-tag-l1menu-collisions2023-v1-0-0-in-run-3-mc-gts-and-run-3-data-relvals-gts/21177

The GT differences are here:

2023 design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/130X_mcRun3_2023_design_v2/130X_mcRun3_2023_design_v3
2023 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/130X_mcRun3_2023_realistic_v3/130X_mcRun3_2023_realistic_v4
2023 cosmic realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/130X_mcRun3_2023cosmics_realistic_deco_v2/130X_mcRun3_2023cosmics_realistic_deco_v3
2023 cosmic design
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/130X_mcRun3_2023cosmics_design_deco_v2/130X_mcRun3_2023cosmics_design_deco_v3
2023 realistic HI
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/130X_mcRun3_2023_realistic_HI_v3/130X_mcRun3_2023_realistic_HI_v4
2024 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/130X_mcRun3_2024_realistic_v3/130X_mcRun3_2024_realistic_v4
Phase2 realistic
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/130X_mcRun4_realistic_v2/130X_mcRun4_realistic_v3

PR validation:

Successfully tested with:
runTheMatrix.py -l 139.001,12434.0,12834.0,23234.0 -j10 --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport but will be backported to 130X

saumyaphor4252 · 2023-03-09T09:12:23Z

@cmsbuild, please test

cmsbuild · 2023-03-09T09:18:21Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41005/34521

This PR adds an extra 12KB to repository

cmsbuild · 2023-03-09T09:18:50Z

A new Pull Request was created by @saumyaphor4252 (Saumya Phor) for master.

It involves the following packages:

Configuration/AlCa (alca)

@tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

missirol · 2023-03-09T09:59:02Z

Hi @saumyaphor4252 , I think the tests will fail, because the current HLT menu is not compatible with the latest L1T menu. What likely needs to happen is that we/HLT need to open a PR to update the HLT menus, then we can test this AlCa PR and the HLT PR together, and they will have to be integrated in the same IB. The same applies to the 13_0_X backport.

The question is how quickly we need to prepare the HLT PR. How long can this PR wait? (1 day, a few days, or else)

francescobrivio · 2023-03-09T10:07:08Z

Hi @saumyaphor4252 , I think the tests will fail, because the current HLT menu is not compatible with the latest L1T menu. What likely needs to happen is that we/HLT need to open a PR to update the HLT menus, then we can test this AlCa PR and the HLT PR together, and they will have to be integrated in the same IB. The same applies to the 13_0_X backport.

The question is how quickly we need to prepare the HLT PR. How long can this PR wait? (1 day, a few days, or else)

Ciao @missirol! Thanks for the feedback!
From the AlCaDB point of view we can hold this PR (and the 13_0_X backport) for now, as currently it is not blocking any other development, but personally I'd prefer not to hold this more than 1 week if possible.

I let @elfontan, as original requestor of the update, to comment on the urgency from the L1T point of view.

elfontan · 2023-03-09T10:12:39Z

Thank you @saumyaphor4252 for the quick preparation of the PR and @missirol and @francescobrivio for the comments!
I do not see any urgency on the L1T side, this update is mostly useful to finalize the preparation and integration of the new HLT menu (compatible with the new L1 menu), so we are fine with STORM timelines.

[Tagging @aloeliger and @epalencia for knowledge]

missirol · 2023-03-09T10:13:10Z

I'd prefer not to hold this more than 1 week if possible.

@francescobrivio , okay. Can you/AlCa also open the 13_0_X backport (without starting the tests)? We will need it to test the HLT PR in 13_0_X once we have it.

francescobrivio · 2023-03-09T10:13:45Z

I'd prefer not to hold this more than 1 week if possible.

@francescobrivio , okay. Can you/AlCa also open the 13_0_X backport (without starting the tests)? We will need it to test the HLT PR in 13_0_X once we have it.

Will do in few minutes

cmsbuild · 2023-03-09T10:55:44Z

-1

Failed Tests: RelVals RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-66f112/31156/summary.html
COMMIT: b9ee609
CMSSW: CMSSW_13_1_X_2023-03-08-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41005/31156/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

139.001

----- Begin Fatal Exception 09-Mar-2023 11:02:08 CET-----------------------
An exception of category 'FailModule' occurred while
   [0] Processing  Event run: 346512 lumi: 250 event: 243042266 stream: 0
   [1] Running path 'HLT_BTagMu_AK8DiJet170_Mu5_v11'
   [2] Calling method for module HLTL1TSeed/'hltL1sMu3JetC120dRMax0p8'
Exception Message:

Algorithm L1_Mu3_Jet120er2p5_dR_Max0p8, requested as seed by a HLT path, cannot be matched to a L1 algo name in any GlobalObjectMap
Please check if algorithm L1_Mu3_Jet120er2p5_dR_Max0p8 is present in the L1 menu

----- End Fatal Exception -------------------------------------------------

12434.0

----- Begin Fatal Exception 09-Mar-2023 11:17:37 CET-----------------------
An exception of category 'FailModule' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'HLT_BTagMu_AK8DiJet170_Mu5_v11'
   [2] Calling method for module HLTL1TSeed/'hltL1sMu3JetC120dRMax0p8'
Exception Message:

Algorithm L1_Mu3_Jet120er2p5_dR_Max0p8, requested as seed by a HLT path, cannot be matched to a L1 algo name in any GlobalObjectMap
Please check if algorithm L1_Mu3_Jet120er2p5_dR_Max0p8 is present in the L1 menu

----- End Fatal Exception -------------------------------------------------

RelVals-INPUT

139.001139.001_RunMinimumBias2021/step2_RunMinimumBias2021.log
139.002139.002_RunZeroBias2021/step2_RunZeroBias2021.log
139.004139.004_RunNoBPTX2021/step2_RunNoBPTX2021.log

Expand to see more relval errors ...

tvami · 2023-03-09T19:27:46Z

@cmsbuild , please test with #41016

cmsbuild · 2023-03-09T22:10:22Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-66f112/31174/summary.html
COMMIT: b9ee609
CMSSW: CMSSW_13_1_X_2023-03-09-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41005/31174/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 1 lines from the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 81 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3525859
DQMHistoTests: Total failures: 979
DQMHistoTests: Total nulls: 95
DQMHistoTests: Total successes: 3524763
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 76692.92400000001 KiB( 48 files compared)
DQMHistoSizes: changed ( 11634.0,... ): 9818.210 KiB HLT/BTV
DQMHistoSizes: changed ( 11634.0,... ): 1531.818 KiB HLT/EXO
DQMHistoSizes: changed ( 11634.0,... ): 1187.008 KiB HLT/TOP
DQMHistoSizes: changed ( 11634.0,... ): 1130.035 KiB HLT/HIG
DQMHistoSizes: changed ( 11634.0,... ): 1056.366 KiB HLT/JME
DQMHistoSizes: changed ( 11634.0,... ): 344.597 KiB HLT/Objects
DQMHistoSizes: changed ( 11634.0,... ): 152.027 KiB HLT/TAU
DQMHistoSizes: changed ( 11634.0,... ): 117.172 KiB HLT/EGM
DQMHistoSizes: changed ( 11634.0,... ): -57.377 KiB HLT/Filters
DQMHistoSizes: changed ( 11634.0,... ): 36.644 KiB HLT/Exotica
DQMHistoSizes: changed ( 11634.0 ): ...
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: found differences in 6 / 47 workflows

francescobrivio · 2023-03-10T10:05:45Z

+alca

diffs are expected and I believe are related to the update of the HLT menu in HLT menu development for 13_0_X (4/N) [13_1_X] #41016

cmsbuild · 2023-03-10T10:06:07Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

rappoccio · 2023-03-10T14:23:40Z

+1

Update L1 menu tag for RelVal and 2023 MC GTs

b9ee609

cmsbuild added this to the CMSSW_13_1_X milestone Mar 9, 2023

cmsbuild added alca-pending pending-signatures tests-pending orp-pending code-checks-pending labels Mar 9, 2023

cmsbuild added tests-started and removed tests-pending labels Mar 9, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 9, 2023

francescobrivio mentioned this pull request Mar 9, 2023

[13_0_X] Update L1 menu tag for data RelVals and 2023/2024, Phase2 MC GTs #41007

Merged

cmsbuild added tests-rejected and removed tests-started labels Mar 9, 2023

missirol mentioned this pull request Mar 9, 2023

HLT menu development for 13_0_X (4/N) [13_1_X] #41016

Merged

cmsbuild added requires-external tests-started and removed tests-rejected labels Mar 9, 2023

cmsbuild removed the tests-started label Mar 9, 2023

cmsbuild added the tests-approved label Mar 9, 2023

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Mar 10, 2023

cmsbuild added orp-approved and removed orp-pending labels Mar 10, 2023

cmsbuild merged commit 98c9b88 into cms-sw:master Mar 10, 2023

cmsbuild mentioned this pull request Mar 10, 2023

MTD geometry: update tests to scenario D95 #41026

Merged

saumyaphor4252 deleted the alca-L1menuTagUpdate branch October 13, 2023 15:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update L1 menu tag for data RelVals and 2023/2024, Phase2 MC GTs #41005

Update L1 menu tag for data RelVals and 2023/2024, Phase2 MC GTs #41005

saumyaphor4252 commented Mar 9, 2023

saumyaphor4252 commented Mar 9, 2023

cmsbuild commented Mar 9, 2023

cmsbuild commented Mar 9, 2023

missirol commented Mar 9, 2023

francescobrivio commented Mar 9, 2023

elfontan commented Mar 9, 2023 •

edited

Loading

missirol commented Mar 9, 2023 •

edited

Loading

francescobrivio commented Mar 9, 2023

cmsbuild commented Mar 9, 2023

tvami commented Mar 9, 2023

cmsbuild commented Mar 9, 2023

francescobrivio commented Mar 10, 2023

cmsbuild commented Mar 10, 2023

rappoccio commented Mar 10, 2023

Update L1 menu tag for data RelVals and 2023/2024, Phase2 MC GTs #41005

Update L1 menu tag for data RelVals and 2023/2024, Phase2 MC GTs #41005

Conversation

saumyaphor4252 commented Mar 9, 2023

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

saumyaphor4252 commented Mar 9, 2023

cmsbuild commented Mar 9, 2023

cmsbuild commented Mar 9, 2023

missirol commented Mar 9, 2023

francescobrivio commented Mar 9, 2023

elfontan commented Mar 9, 2023 • edited Loading

missirol commented Mar 9, 2023 • edited Loading

francescobrivio commented Mar 9, 2023

cmsbuild commented Mar 9, 2023

RelVals

RelVals-INPUT

tvami commented Mar 9, 2023

cmsbuild commented Mar 9, 2023

Comparison Summary

francescobrivio commented Mar 10, 2023

cmsbuild commented Mar 10, 2023

rappoccio commented Mar 10, 2023

elfontan commented Mar 9, 2023 •

edited

Loading

missirol commented Mar 9, 2023 •

edited

Loading