Layer1 unpacker and DQM modified for HCALFB [13_0_X]

[hftsoi]

PR description:

This PR is to modify CaloLayer1 unpacker for proper readout from new fw version at CaloLayer1 about additional HCAL FB implementation. Previously the CaloLayer1 payload data contain only the first FB (FB0) from HCAL, now there is a new fw version that extends the payload data format to contain all other FB (FB1-5), so the unpacker is modified to unpack them. For flexibility there is a flag in the payload header to tell if the additional HCAL FB is implemented or not, therefore two new unpackers (one with UCTCTP7RawData_HCALFB.h for normal event unpacker, another with UCTCTP7RawData5BX_HCALFB.h for fat event unpacker) are added to be used when this flag is set, otherwise the usual unpackers (not for additional HCAL FB implementation) are used and no modification is made to them in this PR. DQM is also modified for these HCAL FB monitoring.

PR validation:

Offline DQM was run on past commissioning runs, expected DQM elements are added.

This PR is closed immediately after opened, and to be sent to DQM team for short production test during coming CRUZET runs, where the new relevant CaloLayer1 fw version will be tested together.

[cmsbuild]

A new Pull Request was created by @hftsoi (Ho-Fung Tsoi) for CMSSW_13_0_X.

It involves the following packages:

• DQM/L1TMonitor (dqm)
• EventFilter/L1TRawToDigi (l1)

@aloeliger, @epalencia, @emanueleusai, @cmsbuild, @syuvivida, @pmandrik, @micsucmed, @cecilecaillol, @rvenditti can you please review it and eventually sign? Thanks.
@dinyar, @missirol, @Martin-Grunewald, @thomreis, @eyigitba this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Layer1 unpacker and DQM modified for HCALFB #41028

[hftsoi]

P5 tests were successful and modifications should stay in production, reopen this PR as a backport of #41028

[emanueleusai]

In the future can we please avoid this closing and re-opening of the PRs? It just makes it confusing to follow the development. I'd recommend to just leave it open until a final decision is made on the integration in a release.

[emanueleusai]

please test

[emanueleusai]

backport of #41028

[emanueleusai]

type hcal

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d24fc/31232/summary.html
COMMIT: 2b54a78
CMSSW: CMSSW_13_0_X_2023-03-12-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41002/31232/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 5 lines from the logs
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3557934
• DQMHistoTests: Total failures: 129
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3557783
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[emanueleusai]

testing at p5

[aloeliger]

In the future can we please avoid this closing and re-opening of the PRs? It just makes it confusing to follow the development. I'd recommend to just leave it open until a final decision is made on the integration in a release.

I would agree with this.

[emanueleusai]

type l1t

[emanueleusai]

+1

• P5 tests successful
• DQM differences understood

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1