Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L1 matching module for VBF+dijet HLT (13_0_X) #41000

Merged
merged 1 commit into from
Mar 20, 2023
Merged

L1 matching module for VBF+dijet HLT (13_0_X) #41000

merged 1 commit into from
Mar 20, 2023

Conversation

portalesHEP
Copy link
Contributor

PR description:

This PR introduces a new matching module for the VBF+dijet trigger that would be implemented in the VBF parking proposal. It based on the already existing L1 VBF jet matching modules that was limited to "3 jet" matching, but here allowing to match 4 to 6 jets.

PR validation:

The module has been implemented and tested with the paths introduced in the menu /users/lportale/VBFparking_13_0_0_pre4/V29.

@cmsbuild cmsbuild added this to the CMSSW_13_0_X milestone Mar 8, 2023
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2023 •
edited
Loading

A new Pull Request was created by @portalesHEP (Louis Portales) for CMSSW_13_0_X.

It involves the following packages:

  • RecoTauTag/HLTProducers (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@silviodonato, @missirol, @azotz, @mbluj this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor

missirol commented Mar 8, 2023

@portalesHEP

Please open a PR to the master branch first. Once that is reviewed and integrated (in a few days), it can be backported to 13_0_X.

@portalesHEP
Copy link
Contributor Author

I opened the PR to master (#41004). Should I close this one while it it reviewed?

@missirol
Copy link
Contributor

missirol commented Mar 9, 2023

Should I close this one while it it reviewed?

No, we can leave it open as is. You will just have to update it eventually to reflect the final version of #41004.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 9, 2023

Pull request #41000 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@missirol
Copy link
Contributor

backport of #41004

@cmsbuild
Copy link
Contributor

Pull request #41000 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

5 similar comments
@cmsbuild
Copy link
Contributor

Pull request #41000 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #41000 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #41000 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #41000 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@cmsbuild
Copy link
Contributor

Pull request #41000 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@portalesHEP portalesHEP force-pushed the VBFparkingModules_VBFdijet branch from d24cfbf to 232ba2d Compare March 13, 2023 22:14
@cmsbuild
Copy link
Contributor

Pull request #41000 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@portalesHEP portalesHEP force-pushed the VBFparkingModules_VBFdijet branch from 232ba2d to ee4ca1a Compare March 14, 2023 11:06
@cmsbuild
Copy link
Contributor

Pull request #41000 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@portalesHEP
L1 matching module for VBF+dijet HLT (Squashed commits)
72149dd 
ÃL1 matching module for VBFÂ+dijet HLT

code-format

Merging new module into L1TJetsMatching

Splitting VBF+dijet specific matching from the 2-3 jet matching default

implementing comments

minor change

throwing exception when incorrect input option

categorise functions as class members

fixing logic for 5 and 6 jets cases

implementing comments
@portalesHEP portalesHEP force-pushed the VBFparkingModules_VBFdijet branch from ee4ca1a to 72149dd Compare March 14, 2023 14:30
@cmsbuild
Copy link
Contributor

Pull request #41000 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

@missirol
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f0cb0f/31276/summary.html
COMMIT: 72149dd
CMSSW: CMSSW_13_0_X_2023-03-14-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41000/31276/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 26 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3551048
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3551019
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

@portalesHEP , please add "(13_0_X)" to the title of this PR for clarity.

@missirol
Copy link
Contributor

+hlt

  • verbatim backport of L1 matching module for VBF+dijet HLT (13_0_X) #41000
  • extends an existing producer used at HLT, without changing its default behaviour, and without changing the results of the current Run-3 HLT menu
  • updated version of the plugin will be available in ConfDB only once a new 13_0_X release is built, and a release template for it is added to ConfDB

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@portalesHEP portalesHEP changed the title L1 matching module for VBF+dijet HLT L1 matching module for VBF+dijet HLT (13_0_X) Mar 17, 2023
@missirol
Copy link
Contributor

@cms-sw/orp-l2 , kind ping to review this backport PR.

@perrotta
Copy link
Contributor

@missirol this is a verbatim backport of #41004
Unless you intend to backport also the possible improvements suggested (by you and by me) and summarized in #41004 (comment) this can get merged even as such: please let us know, since this applies to your domain

@missirol
Copy link
Contributor

I prefer to go ahead with this as is, because it's tied to a HLT JIRA ticket, and possibly a request for a new 13_0_X release.

The improvements can be integrated later on, imho.

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3045400 into cms-sw:CMSSW_13_0_X Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport-ok fully-signed hlt-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_13_0_X
Development

Successfully merging this pull request may close these issues.
4 participants
@portalesHEP @cmsbuild @missirol @perrotta