Add plugin to use existing HLTDoubleSinglet module with two PFJets and one RecoEcalCandidate [13_0_X]

[brallmond]

PR description:

To support future VBF Electron and VBF Photon HLTs in the scenario that VBF Parking is accepted (see JIRA https://its.cern.ch/jira/browse/CMSLITDPG-1099 and https://its.cern.ch/jira/browse/CMSHLT-2702), one plugin is added to the existing plugins file of HLTrigger/HLTfilters.

PR validation:

With the changed file in place, the rates of VBF Electron and VBF Photon were estimated after changing by-hand the EDFilter type to use for the final filter of each path. It was found that events pass both paths and use the triplet filter in the expected way (cross-cleaning a RecoEcalCandidate from two PFJets).

NB: It wasn't obvious to me this was the case at first, but using the same EDFilter module for both electrons and photons is in-line with existing HLT paths and code (see the Ele-Tau cross trigger, which uses a HLT2PhotonTau EDFilter in its cross-cleaning module, hltOverlapFilterIsoEle24IsoTau30WPTightGsfCaloJet5).

Backport

master PR is #40994
It's necessary to Backport this change as current testing and HLT development is taking place in CMSSW_13_0_0

[cmsbuild]

A new Pull Request was created by @brallmond (Braden Allmond) for CMSSW_13_0_X.

It involves the following packages:

• HLTrigger/HLTfilters (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Add plugin to use existing HLTDoubleSinglet module with two PFJets and one RecoEcalCandidate #40994

[missirol]

@brallmond

Please open a PR to the master branch. The latter PR will be considered first. Since the change is simple, please do it in a single commit.

[brallmond]

@brallmond

Please open a PR to the master branch. The latter PR will be considered first. Since the change is simple, please do it in a single commit.

Okay, I have a bit of a beginner question. To make this change in a single commit on this backport PR, should I revise the commit history of this PR (not sure if it is possible since the PR is already made) or close this one and open a new PR for the backport?

[missirol]

To make this change in a single commit on this backport PR, should I revise the commit history of this PR (not sure if it is possible since the PR is already made) or close this one and open a new PR for the backport?

It can be done in this PR, overwriting the branch associated to this PR ("force pushing").

Untested recipe (notice the -f at the end):

cmsrel CMSSW_13_0_0
cd CMSSW_13_0_0/src
cmsenv
git cms-init
git cms-addpkg HLTrigger/HLTfilters
git checkout -b extend-HLTPlugins-HLTDoubletSinglet-DoublePFJetPhoton
git cherry-pick 107b4b58b3c30c5a6c87f6a5a775d73a7b5b163a # from the PR to master
scram b
git push my-cmssw extend-HLTPlugins-HLTDoubletSinglet-DoublePFJetPhoton -f

[missirol]

backport of #40994

[cmsbuild]

Pull request #40991 was updated. @cmsbuild, @missirol, @Martin-Grunewald can you please check and sign again.

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-66be80/31143/summary.html
COMMIT: beba04e
CMSSW: CMSSW_13_0_X_2023-03-08-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40991/31143/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3557934
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3557909
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

• verbatim backport of Add plugin to use existing HLTDoubleSinglet module with two PFJets and one RecoEcalCandidate #40994

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1