Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SiPixelDynamicInefficiency_PayloadInspector fix issue with PU parametrization plot polynomial representation #40981

Merged
merged 1 commit into from
Mar 7, 2023
Merged

SiPixelDynamicInefficiency_PayloadInspector fix issue with PU parametrization plot polynomial representation #40981

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions CondCore/SiPixelPlugins/plugins/SiPixelDynamicInefficiency_PayloadInspector.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -799,6 +799,12 @@ namespace {
auto PhInfo = SiPixelPI::PhaseInfo(SiPixelPI::phase1size);
const auto& regName = this->attachLocationLabel(modules, PhInfo);
namesOfParts.push_back(regName);

edm::LogVerbatim(label_) << "region name: " << regName << " has the following modules attached: ";
for (const auto& module : modules) {
edm::LogVerbatim(label_) << module << ", ";
}
edm::LogVerbatim(label_) << "\n\n";
}

// functional for polynomial of n-th degree
Expand All @@ -824,20 +830,13 @@ namespace {

// push polynomial degree as first entry in the vector
params.insert(params.begin(), n);

// TF1::SetParameters needs a C-style array
double* arr = params.data();
f1->SetLineWidth(2);

if (n == 1) {
/* special case for constant
using setParameters technically works, but leads to
heap-buffer-overflow
*/
f1->SetParameter(0, arr[0]);
f1->SetParameter(1, arr[1]);
} else {
f1->SetParameters(arr);
// fill in the parameter
for (unsigned int j = 0; j < params.size(); j++) {
f1->SetParameter(j, arr[j]);
}

parametrizations.push_back(f1);
Expand Down