run3-alca240X Addition of one more Isolated bunch AlCaReco - backport of #40970 to version 13_0_X

[bsunanda]

PR description:

Addition of one more Isolated bunch AlCaReco - backport of #40970 to version 13_0_X

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backported version

[cmsbuild]

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_13_0_X.

It involves the following packages:

• Configuration/AlCa (alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from Run3-alca240 Add one more isolated bunch AlCaReco to the AlCa matrix #40970

[bsunanda]

@cmsbuild Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a4da5b/31119/summary.html
COMMIT: d4250ff
CMSSW: CMSSW_13_0_X_2023-03-06-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40980/31119/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 11 lines to the logs
• Reco comparison results: 46 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3557934
• DQMHistoTests: Total failures: 117
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3557794
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.016 KiB( 48 files compared)
• DQMHistoSizes: changed ( 1000.0 ): 0.008 KiB MessageLogger/Errors
• DQMHistoSizes: changed ( 1000.0 ): 0.008 KiB MessageLogger/Warnings
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

hold

• I have comments in the master PR

[cmsbuild]

Pull request has been put on hold by @tvami
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

[bsunanda]

@tvami Please unhold this and approve this to go to 13_0_X

[tvami]

unhold

• but there is some mismatch between what Maria told me is needed and the content of this PR, I wrote to her in Mattermost

[tvami]

I wrote to her in Mattermost

I'll approve after this is clarified

[mariadalfonso]

@bsunanda
can you clarify what's the difference between the

HcalCalIsolatedBunchSelector--> this is already in the ZeroBias, and also in the T0 configuration
https://github.com/dmwm/T0/blob/master/etc/ProdOfflineConfiguration.py#L1169

HcalCalIsolatedBunchFilter --> you are trying to add in the Commissioning here (should be followed by a notification to the T0); can this module be replaced by the HcalCalIsolatedBunchSelector ?

[tvami]

I can sign this, but as mentioned by Maria

should be followed by a notification to the T0

it needs to be propagated to the T0 config, it's not read from CMSSW directly

It would be nice if the questions under #40980 (comment) would be clarified

[tvami]

+alca

• see run3-alca240X Addition of one more Isolated bunch AlCaReco - backport of #40970 to version 13_0_X #40980 (comment)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

@bsunanda before merging also this backport PR could you please answer #40980 (comment) (i.e. #40980 (comment))?

[perrotta]

backport of #40970

[bsunanda]

The main difference is one used zero bias and the other needs jet trigger to ensure enough energy in HCAL

[rappoccio]

+1

[tvami]

it needs to be propagated to the T0 config, it's not read from CMSSW directly

I requested it to be added here
https://cms-talk.web.cern.ch/t/add-hcalcalisolatedbunchfilter-to-commissioning-pd-for-900-gev-collisions/21685