Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 13_0_X (3/N) #40966

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Mar 6, 2023

backport of #40965

PR description:

Development of HLT menus for CMSSW_13_0_X.

This PR includes the integration of the following JIRA tickets.

  • CMSHLT-2531: [HIG] use tighter DeepJet b-tag wp in MSSM-Hbb triggers
  • CMSHLT-2606: [PPS] add ExpressPPSRandom stream and PD
  • CMSHLT-2631: [EXO] add 2 diphoton backup triggers to GRun
  • CMSHLT-2641: [TSG] removed unused global PSets (post Run2022)
  • CMSHLT-2642: [TSG] set PS=0 for all MC Paths in all PS columns
  • CMSHLT-2643: [EXO] add eta restriction to delayed-DiPhoton10 triggers
  • CMSHLT-2647: [TSG] removed CUDAService module
  • CMSHLT-2648: [HCAL] remove HLTHcalCalibTypeFilter module from HLT_HcalCalibration_v trigger

It also includes the migration of the HLT menus ("Fake*", frozen, and development ones) to the ConfDB template for CMSSW_13_0_0.

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#40965

Development of HLT menus for 2023 data-taking and Run-3 MC.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2023

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_13_0_X.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

missirol commented Mar 6, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3704de/31106/summary.html
COMMIT: fbbf3a6
CMSSW: CMSSW_13_0_X_2023-03-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40966/31106/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 13 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3557925
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3557900
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor Author

missirol commented Mar 7, 2023

+hlt

Changes in the outputs of PR tests are only due to the change in name of the frozen/fake HLT menus.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2023

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Mar 8, 2023

+1

@cmsbuild cmsbuild merged commit df0d92a into cms-sw:CMSSW_13_0_X Mar 8, 2023
@missirol missirol deleted the HLTdevelopment130X branch March 8, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants