SiPixelPayloadInspectorHelper: fix warning: '<anonymous>' may be used uninitialized

[mmusich]

resolves #40945

PR description:

Title says it all, solved by removing the usage of pointers (which are not needed) in SiPixelPI::topolInfo.

PR validation:

Compiled in CMSSW_13_1_DBG_X_2023-03-02-2300

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[mmusich]

type bug-fix

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40950/34434

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File CondCore/SiPixelPlugins/plugins/SiPixelDynamicInefficiency_PayloadInspector.cc modified in PR(s): prevent heap-buffer-overflow in SiPixelDynamicInefficiencyPUParametrization #40944

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• CondCore/SiPixelPlugins (db)

@malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@VinInn, @mroguljic, @dkotlins, @ferencek, @mmusich, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-371180/31045/summary.html
COMMIT: 696792d
CMSSW: CMSSW_13_1_X_2023-03-02-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40950/31045/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• You potentially added 16 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3529699
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3529676
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mmusich]

@cmsbuild, please test for CMSSW_13_1_DBG_X

• just to see if it compiles without warnings.

[mmusich]

it looks like the compilation for DBG_X is clean: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-371180/31054/build-logs/.

@cms-sw/db-l2 feel free to sign.

[tvami]

+db

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-371180/31054/summary.html
COMMIT: 696792d
CMSSW: CMSSW_13_1_DBG_X_2023-03-02-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40950/31054/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 23234.0

----- Begin Fatal Exception 04-Mar-2023 02:19:11 CET-----------------------
An exception of category 'Invalid DetId' occurred while
   [0] Calling method for module HGCalBackendLayer1Producer/'l1tHGCalBackEndLayer1Producer'
   [1] Prefetching for EventSetup module HGCalTriggerGeometryESProducer/'l1tHGCalTriggerGeometryESProducer'
   [2] Calling method for EventSetup module HGCalGeometryESProducer/'HFNoseGeometryESProducer'
Exception Message:
Cannot initialize HGCSiliconDetId from 6c8bd800
----- End Fatal Exception -------------------------------------------------

[perrotta]

+1

• Errors reported in tests are unrelated

[perrotta]

merge