Modify EMTF unpacker to support new reduced DAQ window for 2023 data taking

[eyigitba]

PR description:

This PR adds a flag to shift BX assignment in EMTF unpacker based on firmware version. In 2023 EMTF will use a reduced DAQ readout window to limit deadtime in high PU scenarios. The unpacker change is done to shift the timing such that the BX range for EMTF is [-2,2] instead of [-3,1].

This option will be enabled in the unpacker for firmware versions dated after 08/12/2022.

PR validation:

Validation done by runTheMatrix.py -l limited -i all --ibeos all tests passed.

Since runTheMatrix probably doesn't have any runs with the new readout I also ran a test on data from last week. See before and after images below. The central BX will be shifted to 0 on the firmware side soon and does not require another update to the unpacker.

Before:

After:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR will be backported to 13_0_X to be used in data taking. However, this is not urgent since it only affects EMTF DQM.

FYI: @kbunkow @bundocka

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40931/34414

• This PR adds an extra 28KB to repository

[cmsbuild]

A new Pull Request was created by @eyigitba for master.

It involves the following packages:

• EventFilter/L1TRawToDigi (l1)

@epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please review it and eventually sign? Thanks.
@dinyar, @missirol, @thomreis, @Martin-Grunewald this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[aloeliger]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ab1eaa/31000/summary.html
COMMIT: 266a3c2
CMSSW: CMSSW_13_1_X_2023-03-02-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40931/31000/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 20 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3529699
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3529672
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[aloeliger]

@eyigitba Does this require letting anybody on DQM know that this change is being made?

[eyigitba]

@aloeliger I'm not sure, but I thought it wasn't necessary. This is due to a change in EMTF DAQ, DQM is affected as a result (it's just restored to normal behaviour). Feel free to tag them though

[aloeliger]

Given that it doesn't touch their code, it is probably okay.

[aloeliger]

If not, maybe one of the core software people would like tag them in.

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1