avoid duplicates in HLTPMMassFilter plugin [13_0_X]

[missirol]

backport of #40918

PR description:

This PR modifies the plugin HLTPMMassFilter in order to (1) consider a given pair of candidates only once when counting how many pairs pass the selection requirements, and (2) avoid duplicates in the candidates added to the TriggerFilterObjectWithRefs output product of this plugin.

Discussed in CMSHLT-2635.

PR description:

None.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#40918

Fix to HLT filter for 2023 data-taking and MC.

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_13_0_X.

It involves the following packages:

• HLTrigger/Egamma (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from avoid duplicates in HLTPMMassFilter plugin #40918

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40919/34404

• This PR adds an extra 16KB to repository

[missirol]

type bugfix

[missirol]

please test

[missirol]

@cms-sw/orp-l2

(just in the interest of clarity)

This potential bugfix came up only after yesterday's ORP. It is not strictly needed for 13_0_0. If HLT signs it, it is a nice-to-have for 13_0_0.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58072e/30978/summary.html
COMMIT: 946df1c
CMSSW: CMSSW_13_0_X_2023-03-01-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40919/30978/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 2 lines to the logs
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3557934
• DQMHistoTests: Total failures: 10
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3557902
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[missirol]

+hlt

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[missirol]

@cms-sw/orp-l2 , could this backport make it into 13_0_0, or do you consider it too late ?

[perrotta]

+1

[missirol]

@cms-sw/orp-l2 , thanks for integrating this in time for 13_0_0.