eg hlt filter threshold reduction to 15 \GeV from 20\GeV

[Soumyatifr]

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Before submitting your pull requests, make sure you followed this checklist:

• verify that the PR is really intended for the chosen branch
• verify that changes follow CMS Naming, Coding, And Style Rules
• verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

[Soumyatifr]

Adding H to gg convener @lfinco here to keep track

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40909/34391

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @Soumyatifr for master.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@cmsbuild, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[swertz]

enable nano

[swertz]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-186f47/30965/summary.html
COMMIT: 180ab5d
CMSSW: CMSSW_13_1_X_2023-02-28-2300/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40909/30965/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 17 lines from the logs
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3529699
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3529674
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

NANO Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 11
• DQMHistoTests: Total histograms compared: 10829
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 10829
• DQMHistoTests: Total skipped: 0
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 10 files compared)
• Checked 23 log files, 10 edm output root files, 11 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.31	2.224	2.224	0.000 ( +0.0% )	9.62	9.66	-0.3%	1.398	1.478
2500.311	2.323	2.323	0.000 ( +0.0% )	9.24	9.32	-0.8%	1.743	1.745
2500.312	2.277	2.277	0.000 ( +0.0% )	9.38	9.36	+0.3%	1.742	1.737
2500.33	1.099	1.099	0.000 ( +0.0% )	22.22	21.98	+1.1%	1.456	1.639
2500.331	1.394	1.394	0.000 ( +0.0% )	16.20	16.19	+0.1%	1.618	1.797
2500.332	1.326	1.326	0.000 ( +0.0% )	18.24	17.97	+1.5%	1.544	1.831
2500.401	2.139	2.139	0.000 ( +0.0% )	10.46	10.40	+0.6%	1.083	1.179
2500.501	1.711	1.711	0.000 ( +0.0% )	16.79	16.65	+0.8%	1.015	1.137
2500.511	1.124	1.124	0.000 ( +0.0% )	31.26	31.42	-0.5%	1.278	1.361
2500.601	2.050	2.050	0.000 ( +0.0% )	12.56	12.54	+0.2%	1.030	1.159

[swertz]

Hi @Soumyatifr , I'm surprised to not see any difference in the tests. Of course this might entirely be due to the samples we use for those tests (e.g. TTbar or Muon data), that wouldn't contain events triggered with low-pt photon paths...

On the other hand, looking at the filters for which the objects are stored, I don't see any such low pt photons either. Are you sure you don't need to add some corresponding filters? A trigger object will only be saved if it passes at least one of the listed filters.

[swagata87]

On the other hand, looking at the filters for which the objects are stored, I don't see any such low pt photons either. Are you sure you don't need to add some corresponding filters? A trigger object will only be saved if it passes at least one of the listed filters.

in a previous PR (#40711), he added this filter -> hltEG18TrackIso60Iso60CaloId15b35eR9Id50b90eHE12b10eR9Id50b80eTrackIsoUnseededFilter
(yeah that's a awfully long name)

it appears here:

cmssw/PhysicsTools/NanoAOD/python/triggerObjects_cff.py

Line 102 in 3547eea

mksel("filter('hltEG18TrackIso60Iso60CaloId15b35eR9Id50b90eHE12b10eR9Id50b80eTrackIsoUnseededFilter')","hltEG18TrackIso60Iso60CaloId15b35eR9Id50b90eHE12b10eR9Id50b80eTrackIsoUnseededFilter")

It's a photon leg with 18 GeV Et cut

[swertz]

Thanks @swagata87 , I'd overlooked that one - and indeed also in #40711 there were no events in the tests passing that filter, due to the choice of samples... All good then.

[swertz]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

[vlimant]

is there a 13.0 back port expected for this ?

[swertz]

Indeed, @Soumyatifr can you please take care?

[swertz]

@Soumyatifr , kind ping for a backport to 13_0_X.

[swertz]

Hi @Soumyatifr @swagata87 just a reminder that if you want this included for NanoAODv12 and 2023 data prompt NanoAOD, there should be a backport to 13_0_X.

[swagata87]

I was expecting that Soumya or someone from Higgs to gamma gamma would respond to this. They are the primary user of the HLT path/filter in question here. I will send an email to the Hgg convenors now.

[lfinco]

Yes, Soumya is going to take care of it, just pinged.

[Soumyatifr]

Hi @swertz Here it is: #41115