[12.5.X] Disentangle TrackerTrackHitFilter from phase-0 Strip conditions

[mmusich]

partial backport of #40835

PR description:

The common alignment track selection and refitting sequence currently cannot run in Phase-2 setups because of missing Phase-0 SiStrip conditions. The module TrackerTrackHitFilter indeed requires at construction time the following conditions:

----- Begin Fatal Exception 21-Feb-2023 12:46:22 CET-----------------------
An exception of category 'NoRecord' occurred while
   [0] Processing  Event run: 1 lumi: 67 event: 6602 stream: 0
   [1] Running path 'p2'
   [2] Prefetching for module TrackerTrackHitFilter/'TrackerTrackHitFilter'
   [3] Prefetching for EventSetup module SiStripQualityESProducer/'siStripQualityESProducer'
   [4] Calling method for EventSetup module SiStripConnectivity/'sistripconn'
   [5] While getting dependent Record from Record SiStripDetCablingRcd
Exception Message:
No "SiStripFedCablingRcd" record found in the EventSetup.

 Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------

As it seems that adding Phase-0 SiStrip conditions (either in GT or by dedicated ESSource) would be a wrong design choice, the goal of this PR is allow TrackerTrackHitFilter to run without Phase-0 SiStrip conditions, by means of adding a new parameter isPhase2 that governs if the SiStripClusterInfo object used in TrackerTrackHitFilter should be constructed or not with an esConsumes call.
This is achieved by using std::optional to declare the SiStripClusterInfo data member and construct it only if the workflow is not meant for Phase-2.

PR validation:

run dedicated private tests.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

partial backport of #40835 to be able to be used in the phase-2 alignment studies happening in that cycle (see PdmV JIRA ticket)

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_5_X.

It involves the following packages:

• RecoTracker/FinalTrackSelectors (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @missirol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from [12.6.X] Disentangle TrackerTrackHitFilter from phase-0 Strip conditions #40897

[mmusich]

please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18a2be/30959/summary.html
COMMIT: f732d4f
CMSSW: CMSSW_12_5_X_2023-02-26-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40898/30959/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• You potentially added 6 lines to the logs
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3724047
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3724023
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 216 log files, 167 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

backport of #40897
(in addition to being partial backport of #40835)

[mandrenguyen]

+reconstruction
(disregarding relval input errors)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_5_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• Not sure whether a new 12_5_X release is needed for the Phase2Fall22 campaign, and a bit weird that it was not discussed during the last ORP.
• Let have this merged anyhow, just in case.

[perrotta]

merge

[mmusich]

@perrotta

Not sure whether a new 12_5_X release is needed for the Phase2Fall22 campaign, and a bit weird that it was not discussed during the last ORP.

strictly speaking it's not used for the campaign itself. If a new release is cut (for whatever other reason), this would allow to analyze the data natively, but I guess the patch is small enough to just merge the commits locally.