-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop unused lto flags in BigProducts/Simulation
BuildFile
#40892
Conversation
A new Pull Request was created by @cmsbuild for CMSSW_13_0_X. It involves the following packages:
@smuzaffar, @civanch, @Dr15Jones, @makortel, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here
|
please test this is a backport and is needed to enable LTO for 13.0.x |
+core |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Expand to see more relval errors ...Comparison SummarySummary:
|
+1 |
merge |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-aa12aa/30939/summary.html Comparison SummarySummary:
|
backport of #40857
Hello,
We are enabling LTO for IBs (See cms-sw/cmsdist#8332 and cms-sw/cms-bot#1943) and we have realized there is this build file dropping some flags in case release name does not contain
_LTO_
. Those flags are not used anymore, so we would need to drop this condition.Thanks,
Andrea.
FYI, @smuzaffar