Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tracks related Pixel quantities at HLT DQM (backport) #40875

Merged
merged 5 commits into from
Mar 1, 2023
Merged

Fix Tracks related Pixel quantities at HLT DQM (backport) #40875

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4c89858
Introduce track refitting in HLT DQM for Pixel Tracks quantities
Feb 22, 2023
5f46737
Add Pixel Template to HLT Online client
Feb 24, 2023
0e9baea
Fix a typo on SiPixel_OfflineMonitor sequence
Feb 24, 2023
014e922
Modification to protect the process when some collection are not avai…
Feb 25, 2023
d943f6f
drop cms type specifications
Feb 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions DQM/Integration/python/clients/hlt_dqm_sourceclient-live_cfg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,8 @@
)
#SiStrip Local Reco
process.load("CalibTracker.SiStripCommon.TkDetMapESProducer_cfi")
#Track refitters
process.load("RecoTracker.TrackProducer.TrackRefitters_cff")

#---- for P5 (online) DB access
process.load("DQM.Integration.config.FrontierCondition_GT_cfi")
Expand Down
4 changes: 2 additions & 2 deletions DQM/SiPixelPhase1Track/python/SiPixelPhase1TrackResiduals_cfi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,8 +134,8 @@

from DQMServices.Core.DQMEDAnalyzer import DQMEDAnalyzer
SiPixelPhase1TrackResidualsAnalyzer = DQMEDAnalyzer('SiPixelPhase1TrackResiduals',
trajectoryInput = cms.string("generalTracks"),
Tracks = cms.InputTag("generalTracks"),
trajectoryInput = cms.string("refittedForPixelDQM"),
Tracks = cms.InputTag("refittedForPixelDQM"),
vertices = cms.InputTag("offlinePrimaryVertices"),
histograms = SiPixelPhase1TrackResidualsConf,
geometry = SiPixelPhase1Geometry,
Expand Down
2 changes: 1 addition & 1 deletion DQMOffline/Trigger/python/SiPixel_OfflineMonitoring_TrackCluster_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@
hltSiPixelPhase1TrackClustersAnalyzer = DQMEDAnalyzer('SiPixelPhase1TrackClusters',
VertexCut = cms.untracked.bool(False),
clusters = cms.InputTag("hltSiPixelClusters"),
tracks = cms.InputTag("hltMergedTracks"), #hltIter2Merged"
tracks = cms.InputTag("hltrefittedForPixelDQM"),
clusterShapeCache = cms.InputTag("hltSiPixelClusterShapeCache"),
vertices = cms.InputTag(""),
histograms = hltSiPixelPhase1TrackClustersConf,
Expand Down
13 changes: 11 additions & 2 deletions DQMOffline/Trigger/python/SiPixel_OfflineMonitoring_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,17 @@

from DQMOffline.Trigger.SiPixel_OfflineMonitoring_Cluster_cff import *
from DQMOffline.Trigger.SiPixel_OfflineMonitoring_TrackCluster_cff import *
from RecoPixelVertexing.PixelLowPtUtilities.siPixelClusterShapeCache_cfi import *
from DQM.SiPixelMonitorTrack.RefitterForPixelDQM import *

hltSiPixelClusterShapeCache = siPixelClusterShapeCache.clone(src = 'hltSiPixelClusters')
hltrefittedForPixelDQM = refittedForPixelDQM.clone(src ='hltMergedTracks',
TTRHBuilder = 'WithTrackAngle') # no templates at HLT


sipixelMonitorHLTsequence = cms.Sequence(
hltSiPixelPhase1ClustersAnalyzer
#+ hltSiPixelPhase1TrackClustersAnalyzer
hltSiPixelClusterShapeCache
+ hltSiPixelPhase1ClustersAnalyzer
+ hltrefittedForPixelDQM
+ hltSiPixelPhase1TrackClustersAnalyzer
)
7 changes: 7 additions & 0 deletions RecoPixelVertexing/PixelLowPtUtilities/plugins/SiPixelClusterShapeCacheProducer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,13 @@ void SiPixelClusterShapeCacheProducer::produce(edm::StreamID, edm::Event& iEvent
edm::Handle<InputCollection> input;
iEvent.getByToken(token_, input);

if (!input.isValid()) {
edm::LogError("siPixelClusterShapeCache") << "input pixel cluster collection is not valid!";
auto output = std::make_unique<SiPixelClusterShapeCache>();
iEvent.put(std::move(output));
return;
}

const auto& geom = &iSetup.getData(geomToken_);

auto output = std::make_unique<SiPixelClusterShapeCache>(input);
Expand Down