improve HLTMuonValidator and HLTMuonPlotter (no UB, consider only HLTFilter modules) [13_0_X]

[missirol]

backport of #40753

PR description:

From the description of #40753:

This PR aims to improve the plugin HLTMuonValidator, and its utility HLTMuonPlotter.

This update was triggered by #40708 (comment), where it was noticed that HLTMuonPlotter has a bug that can lead to undefined behaviour [1].

Further checks showed other shortcomings of HLTMuonValidator/HLTMuonPlotter (see review comments for more details); these shortcomings can lead to the DQM outputs of HLTMuonValidator being filled incorrectly in the current implementation. This PR tries to fix this (on top of fixing the original UB issue).

LogTrace calls are added to ease debugging. In addition, technical changes to modernise both classes are applied (e.g. const correctness).

Expect changes in the DQM outputs of HLTMuonValidator (and nowhere else).

[1]
The value of hltStep becomes (size_t) -1 when step == 2 and nSteps == 6, leading to undefined behaviour in

cmssw/HLTriggerOffline/Muon/src/HLTMuonPlotter.cc

Line 221 in 6f5b833

if (matches[j].candHlt[hltStep] == nullptr)

This was originally reported in #12056, but apparently not fixed back then.

PR validation:

None beyond the checks done for #40753.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

#40753

Fix to HLT offline DQM in release cycle for 2023 pp data-taking.

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_13_0_X.

It involves the following packages:

• HLTriggerOffline/Muon (dqm)

@emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks.
@mtosi, @andrea21z, @abbiendi, @Fedespring, @HuguesBrun, @jhgoh, @CeliaFernandez, @trocino, @cericeci this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

• Backported from improve HLTMuonValidator and HLTMuonPlotter (no UB, consider only HLTFilter modules) #40753

[missirol]

type bugfix

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a170bf/30873/summary.html
COMMIT: 0e1ce07
CMSSW: CMSSW_13_0_X_2023-02-23-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40871/30873/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
22034.911 step 1
23234.911 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• You potentially added 20 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3556944
• DQMHistoTests: Total failures: 1155
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555767
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 78.21 KiB( 48 files compared)
• DQMHistoSizes: changed ( 11634.0,... ): 13.035 KiB HLT/Muon
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

DQM differences as expected (see master PR)

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1