Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-gex155 Make the additional Run3 files as the step1 to make the payload for Run3 #40865

Merged
merged 2 commits into from
Feb 25, 2023

Conversation

bsunanda
Copy link
Contributor

PR description:

Make the additional Run3 files as step 1 to make the payload for Run3. All these files are needed to make the payload

PR validation:

Use the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Need to be back ported to CMSSW_13_0_X

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40865/34334

  • This PR adds an extra 40KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

  • Configuration/Geometry (geometry, upgrade)
  • Configuration/StandardSequences (operations)
  • Geometry/CMSCommonData (geometry, upgrade)

@perrotta, @rappoccio, @Dr15Jones, @bsunanda, @makortel, @civanch, @mdhildreth, @AdrianoDee, @srimanob, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @vargasa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @kpedro88, @mmusich, @sameasy, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d837ef/30861/summary.html
COMMIT: fda058b
CMSSW: CMSSW_13_1_X_2023-02-23-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40865/30861/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test test2021Geometry had ERRORS

Comparison Summary

There are some workflows for which there are errors in the baseline:
22034.911 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 11 lines to the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3528709
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3528684
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40865/34336

  • This PR adds an extra 40KB to repository

@bsunanda
Copy link
Contributor Author

+geometry

@bsunanda
Copy link
Contributor Author

@srimanob Please approve this

@civanch
Copy link
Contributor

civanch commented Feb 24, 2023

@bsunanda , may in the title and description to add "new files for 2023 Run3 geometry"? As I understand our approach for geometry, we have to make all these new configuration files even if the real change is only for one chamber.

@srimanob
Copy link
Contributor

test parameters:

  • workflow = 12434.911
  • relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,ged,machine,premix,nano,gpu
  • pull_request = Add 2023 DD4hep XML wf #40881

@srimanob
Copy link
Contributor

srimanob commented Feb 25, 2023

@cmsbuild please test

As this PR introduces DD4hep XML for 2023. I've modified .911 to accept 2023 as well. Let's test.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d837ef/30900/summary.html
COMMIT: 2efc5be
CMSSW: CMSSW_13_1_X_2023-02-24-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40865/30900/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 7 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3528955
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3528933
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

+Upgrade

The workflow 12434.911 (2023 DD4hep XML) runs fine.

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit c15115c into cms-sw:master Feb 25, 2023
cmsbuild added a commit that referenced this pull request Feb 27, 2023
Run3-gex155X Backport #40865 to CMSSW_13_0_X for additional Run3 files needed as the step1 for making 2023 geometry payload
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants