Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport] uGT fix for muon showers full emulation and for HMT mismatches in the DQM workflow #40861

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

elfontan
Copy link
Contributor

PR description:

Backport of #40773 to CMSSW_13_0_X targeting the first release created for the 2023 data-taking.

The purpose of this PR is to address multiple issues at the GT level related to the muon shower emulation. Here two main items are discussed:

  1. uGT emulation of HMT
  2. DQM mismatches

All details can be found in the conversation of the main PR.
Thanks @eyigitba and @aloeliger for the work and the discussion.

PR validation:

Basic tests performed successfully starting from CMSSW_13_0_X_2023-02-21-1100

cmsrel CMSSW_13_0_X_2023-02-21-1100
cd CMSSW_13_0_X_2023-02-21-1100/src
cmsenv
git cms-addpkg L1Trigger/L1TGlobal
git cms-addpkg DQM/L1TMonitor
scram b distclean
git cms-checkdeps -a -A
scram b -j 8
scram b runtests
scram build code-checks
scram build code-format

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 23, 2023

A new Pull Request was created by @elfontan (Elisa Fontanesi) for CMSSW_13_0_X.

It involves the following packages:

  • DQM/L1TMonitor (dqm)
  • L1Trigger/L1TGlobal (l1)

@aloeliger, @epalencia, @emanueleusai, @cmsbuild, @syuvivida, @pmandrik, @micsucmed, @cecilecaillol, @rvenditti can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@elfontan elfontan changed the title Fix of the HMT emulation and DQM mismatches [Backport] uGT fix for muon showers full emulation and for HMT mismatches in the DQM workflow Feb 23, 2023
@aloeliger
Copy link
Contributor

backport of #40773

@emanueleusai
Copy link
Member

please test

@emanueleusai
Copy link
Member

type l1t

@cmsbuild cmsbuild added the l1t label Feb 24, 2023
@emanueleusai
Copy link
Member

backport of #40773

@elfontan elfontan marked this pull request as ready for review February 24, 2023 10:08
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d594d8/30870/summary.html
COMMIT: 907a0d9
CMSSW: CMSSW_13_0_X_2023-02-23-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40861/30870/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
22034.911 step 1
23234.911 step 1
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 11 lines to the logs
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3556944
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3556916
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 7d8d669 into cms-sw:CMSSW_13_0_X Feb 27, 2023
@elfontan elfontan deleted the EF_backport130X_uGT_fixHMT branch April 3, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants