-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-gex154B Fix the issue of 2026D91 which can now work in the dd4hep version #40838
Conversation
@cmsbuild Please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40838/34292
|
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master. It involves the following packages:
@civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@bsunanda could you please add to the description what is the issue that this PR is fixing? |
please abort |
test parameters:
|
@cmsbuild please test |
-1 Failed Tests: RelVals RelValsValueError: Undefined workflows: 22034.911 |
test parameters: |
test parameters:
|
@cmsbuild please test |
Pull request #40838 was updated. @perrotta, @rappoccio, @Dr15Jones, @bsunanda, @makortel, @civanch, @mdhildreth, @AdrianoDee, @srimanob, @fabiocos, @davidlange6 can you please check and sign again. |
@srimanob As you see it was in GeometryConf.py |
@srimanob please uphold this and put it as a bug fix. Like to backport this to 13_0 |
unhold |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a0517d/30831/summary.html Comparison SummarySummary:
|
+1 |
type bug-fix |
@srimanob please approve this PR |
+Upgrade |
@perrotta @rappoccio Please approve and integrate this bug fix. Need to backport this to 13_0_X |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged. |
PR description:
Fix the issue of 2026D91 which can now work in the dd4hep version. In the earlier version, any cmdim job with this scenario and dd4hep used to crash in the very first event with
----- Begin Fatal Exception 21-Feb-2023 12:20:44 CET-----------------------
An exception of category 'NoProxyException' occurred while
[0] Processing global begin Run run: 1
[1] Prefetching for module OscarMTProducer/'g4SimHits'
[2] Calling method for EventSetup module TrackerGeometricDetESModule/'trackerNumberingGeometry'
Exception Message:
No data of type "DDCompactView" with label "" in record "IdealGeometryRecord"
Now the dd4hep job with that scenario runs normally
PR validation:
Use the runTheMatrix test workflows
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Need to be back ported to 13_0_X