-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements on measurement methodology of ZCounting #40815
Conversation
…nd outer track pT, |eta|, and dR are now added in the global muon requirement; The global muon efficiency is now measured using the merged standalone collection and using the outer track parameters; The standalone muon efficiency is measured using only tracks that are not muon seeded and a dR matching to an outer track is performed (instead of taking the reference).
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40815/34258
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40815/34261
|
A new Pull Request was created by @davidwalter2 for master. It involves the following packages:
@emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8798f/30746/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
Hi @emanueleusai, is a backport needed for this to go into the release for 2023 data taking? |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40815/34295
|
Pull request #40815 was updated. @emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please check and sign again. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40815/34296
|
Pull request #40815 was updated. @emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8798f/30790/summary.html Comparison SummarySummary:
|
@davidwalter2 yes we need the 13_0 backport |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
DQMOffline/Lumi zcounting backport of PR #40815 [CMSSW_13_0_X]
PR description:
Histograms are added to allow to correct measure the inner and outer muon track efficiencies. Further changes are done:
Only DQMOffline/Lumi will be affected by those changes
PR validation:
The code was validated using cmsDriver.py in CMSSW_12_4_12. It was also compared to a offline standalone implementation and identical results, as desired, were obtained.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
It should get merged in time for the 2023 data taking