Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-gex335R Backport #40644 to CMSSW_13_0_X to complete v17 definition of HGCal with different lateral sizes of the components inside a silicon module #40781

Merged
merged 5 commits into from
Feb 21, 2023

Conversation

bsunanda
Copy link
Contributor

PR description:

Backport #40644 to complete v17 definition of HGCal with different lateral sizes of the components inside a silicon module. This PR affects mainly all workflows which use V17 or V17n geometry versions of HGCal

PR validation:

Tested using the runTheMatrix test workflows

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of the PR #40644

…ent lateral sizes of the components inside a silicon module
@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 16, 2023

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_13_0_X.

It involves the following packages:

  • Geometry/HGCalCommonData (geometry, upgrade)

@civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks.
@fabiocos this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@bsunanda
Copy link
Contributor Author

type backport

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-54c88e/30654/summary.html
COMMIT: d9d3968
CMSSW: CMSSW_13_0_X_2023-02-15-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40781/30654/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 9 lines from the logs
  • Reco comparison results: 3504 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3556272
  • DQMHistoTests: Total failures: 4473
  • DQMHistoTests: Total nulls: 64
  • DQMHistoTests: Total successes: 3551713
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

Pull request #40781 was updated. @civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again.

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-54c88e/30655/summary.html
COMMIT: cba2528
CMSSW: CMSSW_13_0_X_2023-02-15-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40781/30655/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 27 lines from the logs
  • Reco comparison results: 3496 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3556272
  • DQMHistoTests: Total failures: 4470
  • DQMHistoTests: Total nulls: 64
  • DQMHistoTests: Total successes: 3551716
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

+Upgrade

Backport PR. Just to note, we currently have no plan to use C17 for 13_0 Phase-2 production as we never make relvals and make a call for validation. Not clear the goal of backport but it is harmless to update.

@civanch
Copy link
Contributor

civanch commented Feb 16, 2023

+1

@bsunanda bsunanda changed the title Phase2-gex335R Backport #40644 to complete v17 definition of HGCal with different lateral sizes of the components inside a silicon module Phase2-gex335R Backport #40644 to CMSSW_13_0_X to complete v17 definition of HGCal with different lateral sizes of the components inside a silicon module Feb 17, 2023
@cmsbuild
Copy link
Contributor

Pull request #40781 was updated. @civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again.

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-54c88e/30708/summary.html
COMMIT: 492fd68
CMSSW: CMSSW_13_0_X_2023-02-16-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40781/30708/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 11 lines to the logs
  • Reco comparison results: 3585 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3556272
  • DQMHistoTests: Total failures: 5131
  • DQMHistoTests: Total nulls: 67
  • DQMHistoTests: Total successes: 3551052
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@bsunanda
Copy link
Contributor Author

+geometry

@bsunanda
Copy link
Contributor Author

@srimanob Please approve this

@bsunanda
Copy link
Contributor Author

@srimanob @perrotta Please approve this PR and integrate thus

@bsunanda
Copy link
Contributor Author

@srimanob @perrotta @rappoccio Could you approve this and integrate this?

@srimanob
Copy link
Contributor

+Upgrade

Backport PR

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a3b3d4e into cms-sw:CMSSW_13_0_X Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants