-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase2-gex335R Backport #40644 to CMSSW_13_0_X to complete v17 definition of HGCal with different lateral sizes of the components inside a silicon module #40781
Conversation
…ent lateral sizes of the components inside a silicon module
A new Pull Request was created by @bsunanda (Sunanda Banerjee) for CMSSW_13_0_X. It involves the following packages:
@civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild Please test |
type backport |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-54c88e/30654/summary.html Comparison SummarySummary:
|
Pull request #40781 was updated. @civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again. |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-54c88e/30655/summary.html Comparison SummarySummary:
|
+Upgrade Backport PR. Just to note, we currently have no plan to use C17 for 13_0 Phase-2 production as we never make relvals and make a call for validation. Not clear the goal of backport but it is harmless to update. |
+1 |
Pull request #40781 was updated. @civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob can you please check and sign again. |
@cmsbuild Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-54c88e/30708/summary.html Comparison SummarySummary:
|
+geometry |
@srimanob Please approve this |
@srimanob @perrotta @rappoccio Could you approve this and integrate this? |
+Upgrade Backport PR |
This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Backport #40644 to complete v17 definition of HGCal with different lateral sizes of the components inside a silicon module. This PR affects mainly all workflows which use V17 or V17n geometry versions of HGCal
PR validation:
Tested using the runTheMatrix test workflows
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of the PR #40644