-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"CICADA"/calorimeter anomaly detection trigger emulator using external repositories #40779
"CICADA"/calorimeter anomaly detection trigger emulator using external repositories #40779
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40779/34209
|
A new Pull Request was created by @aloeliger (Andrew Loeliger) for master. It involves the following packages:
@epalencia, @cmsbuild, @cecilecaillol, @rekovic can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fdfa4d/30772/summary.html Comparison SummarySummary:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40779/34323
|
Pull request #40779 was updated. @epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please check and sign again. |
please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUTThe relvals timed out after 4 hours. Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40779/34356
|
Pull request #40779 was updated. @epalencia, @cmsbuild, @cecilecaillol, @aloeliger can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-fdfa4d/30904/summary.html Comparison SummarySummary:
|
@cecilecaillol could I ask you to look at this and sign again? I can make the commits or I can sign them, but if I do both CMS is probably in trouble, and so am I. |
+l1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR represents the emulator of the Princeton University/University of Wisconsin unsupervised L1T anomaly detection technique using Calo L1 ("CICADA").
HLS4ML models are now loaded from externally compiled repository
.so
libraries, via an interface provided via thehls4mlEmulatorExtras
external. The CICADA model used in the emulator represents the first version of CICADA to be tested on trigger testing hardware, and is loaded from theCICADA
external asCICADAModel_v1
.This PR supersedes #40277.
PR validation:
Due to this emulator not being associated with any standard workflows yet, no changes are expected to standard workflows, and they are not useful in validation. All code compiles, and has had code formatting applied. We have performed internal validation of the output of this emulator with a dedicated ntuplizer on data and MC, and it produces values in line with what is seen in firmware testing. If additional validation checks are desired, the CICADA team can discuss providing them or performing them upon request.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
This PR is not a backport