stop using bare ROOT objects in HLTDQMHist* classes

[missirol]

PR description:

This PR tries to implement the suggestion in #40676 (comment), to avoid accessing bare ROOT objects (via MonitorElement) in the HLTDQMHist*D classes of the HLT offline DQM.

Minor cleanup is also applied to HLTTagAndProbeOfflineSource<..>::fillDescriptions.

Merely technical. No changes expected.

FYI: @Sam-Harper

PR validation:

runTheMatrix.py -l 11634.0 passed.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

To be backported to CMSSW_13_0_X if merged down to CMSSW_12_4_X.

[missirol]

This change is unrelated to the main goal of this PR. It correctly creates the following cfi files (one per template instantiation):

"${CMSSW_BASE}"/cfipython/"${SCRAM_ARCH}"/DQMOffline/Trigger/hltElePhoTagAndProbeOfflineSource_cfi.py
"${CMSSW_BASE}"/cfipython/"${SCRAM_ARCH}"/DQMOffline/Trigger/hltEleTagAndProbeOfflineSource_cfi.py
"${CMSSW_BASE}"/cfipython/"${SCRAM_ARCH}"/DQMOffline/Trigger/hltMuEleTagAndProbeOfflineSource_cfi.py
"${CMSSW_BASE}"/cfipython/"${SCRAM_ARCH}"/DQMOffline/Trigger/hltMuPhoTagAndProbeOfflineSource_cfi.py
"${CMSSW_BASE}"/cfipython/"${SCRAM_ARCH}"/DQMOffline/Trigger/hltMuTagAndProbeOfflineSource_cfi.py
"${CMSSW_BASE}"/cfipython/"${SCRAM_ARCH}"/DQMOffline/Trigger/hltPhoTagAndProbeOfflineSource_cfi.py

[missirol]

This does not seem to be used, so it is removed.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40760/34178

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

• DQMOffline/Trigger (dqm)

@emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks.
@mtosi, @Fedespring, @HuguesBrun, @jhgoh, @trocino, @cericeci, @rociovilar this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[missirol]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4dca3f/30620/summary.html
COMMIT: d2599d8
CMSSW: CMSSW_13_1_X_2023-02-13-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40760/30620/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 20 lines from the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555972
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555947
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[missirol]

As expected, I don't see differences in the DQM outputs related to this PR. (I updated the PR description to clarify this).

[Sam-Harper]

thanks Marino, I wasnt aware of the original comment. Much appreciated for you taking care of it.

[missirol]

type bugfix

@cms-sw/dqm-l2 , could you please review this PR?

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1