Extended SimpleMemoryCheck to print RSS info to the logger

[Dr15Jones]

PR description:

The service now prints both VSize and RSS info in its summary.

PR validation:

A test job shows the new output.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40749/34162

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• FWCore/Services (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit, @fwyzard this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-650862/30588/summary.html
COMMIT: 9437322
CMSSW: CMSSW_13_0_X_2023-02-10-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40749/30588/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 18 lines from the logs
• Reco comparison results: 1 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555972
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555947
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• This PR extends the printout of SimpleMemoryCheck, without modifying any object in the Event: therefore it can be merged in 13_0_X even before switching the master to 13_1_X, to make it already available also in 13_0_X

[makortel]

I suspect this PR caused the GeometryTrackerGeometryBuilderTestDriver test to fail

===== Compare Tracker Parameters for DD and DD4hep ====
The output diff is 932:
72c72
< MemoryReport> Peak virtual size 794.656 Mbytes
---
> MemoryReport> Peak virtual size 713.266 Mbytes
76c76
< [1] run: 1 lumi: 1 event: 1  vsize = 794.656 deltaVsize = 0 rss = 215.047 delta = 0
---
> [1] run: 1 lumi: 1 event: 1  vsize = 713.266 deltaVsize = 0 rss = 158.809 delta = 0
81,82c81,82
< [1] run: 1 lumi: 1 event: 1  vsize = 794.656 deltaVsize = 0 rss = 215.047 delta = 0
< MemoryReport> Peak rss size 215.047 Mbytes
---
> [1] run: 1 lumi: 1 event: 1  vsize = 713.266 deltaVsize = 0 rss = 158.809 delta = 0
> MemoryReport> Peak rss size 158.809 Mbytes
86c86
< [1] run: 1 lumi: 1 event: 1  vsize = 794.656 deltaVsize = 0 rss = 215.047 delta = 0
---
> [1] run: 1 lumi: 1 event: 1  vsize = 713.266 deltaVsize = 0 rss = 158.809 delta = 0
89c89
< [1] run: 1 lumi: 1 event: 1  vsize = 794.656 deltaVsize = 0 rss = 215.047 delta = 0
---
> [1] run: 1 lumi: 1 event: 1  vsize = 713.266 deltaVsize = 0 rss = 158.809 delta = 0
Failure comparing Tracker Parameters for DD and DD4hep: status 255
status = 65280

---> test GeometryTrackerGeometryBuilderTestDriver had ERRORS

https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc7_amd64_gcc11/CMSSW_13_0_X_2023-02-13-1100/unitTestLogs/Geometry/TrackerGeometryBuilder#/

The proper fix would be to make the test either not use the SimpleMemoryCheck service, or ignore its output in the comparison.