Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QGL, JMENanoAOD] Backport of #40667 (PUPPI-compatible QGTagger producer) to 12_6_X #40740

Merged

Conversation

nurfikri89
Copy link
Contributor

@nurfikri89 nurfikri89 commented Feb 10, 2023

Backport from #40667

Original PR description:

The main goal of this PR is to modify QGTagger producer (used to compute Quark-Gluon (QG) Likelihood) so that it is compatible with PUPPI jets. The QGTagger calculates three input variables, used to compute the likelihood, from PF constituents of jets. The changes in this PR allows the QGTagger to compute the input variables with PUPPI weights applied on the PF constituents by accessing the weights from the provided ValueMap<float>. This can also be done for any constituents weights, not just PUPPI. Additionally, this PR makes it optional to not compute the likelihood and calculate just the three input variables for users who wants only them.

With these modifications of the QGTagger, it should not affect CHS jets so we do not expect to see any change to the output of workflows. The QGTagger is currently scheduled to run only for AK4 CHS jets at the MiniAOD and (Run-2) NanoAOD production level.

Other changes:

  • some fixes for JMENanoAOD.
  • fine-tune histograms in nanoDQM for JMENano.

Backport PR validation:

  • Validation plots comparing the input variables before and after the fix can be found in this JMAR meeting contribution.
  • passes reMiniAOD and reNanoAOD workflows: runTheMatrix.py -i all --ibeos -l 1325.518,2500.312
  • passes the JMENano workflows: runTheMatrix.py -i all --ibeos -l 10224.15,11024.15,25202.15,11634.15

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 10, 2023

A new Pull Request was created by @nurfikri89 (Nurfikri Norjoharuddeen) for CMSSW_12_6_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)
  • PhysicsTools/PatAlgos (xpog, reconstruction)
  • RecoJets/JetProducers (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @yslai, @hatakeyamak, @emilbols, @mbluj, @demuller, @seemasharmafnal, @mmarionncern, @missirol, @ahinzmann, @jdolen, @azotz, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso, @clelange, @AlexDeMoor, @AnnikaStein, @JyothsnaKomaragiri, @gpetruc, @andrzejnovak this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@swertz
Copy link
Contributor

swertz commented Feb 10, 2023

enable nano

@swertz
Copy link
Contributor

swertz commented Feb 10, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5b4d5b/30569/summary.html
COMMIT: 193817f
CMSSW: CMSSW_12_6_X_2023-02-09-2300/el8_amd64_gcc10
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40740/30569/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460357
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3460329
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 8 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 15414
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 15414
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 31 log files, 14 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.31 2.209 2.209 0.000 ( +0.0% ) 9.25 9.16 +1.0% 1.586 1.584
2500.311 2.329 2.329 0.000 ( +0.0% ) 8.78 8.75 +0.4% 1.953 1.947
2500.312 2.284 2.284 0.000 ( +0.0% ) 9.00 8.86 +1.6% 1.939 1.939
2500.33 1.096 1.096 0.000 ( +0.0% ) 21.63 21.17 +2.1% 1.697 1.697
2500.331 1.396 1.396 0.000 ( +0.0% ) 15.61 15.50 +0.8% 1.847 1.851
2500.332 1.328 1.328 0.000 ( +0.0% ) 17.41 17.28 +0.8% 1.801 1.803
2500.4 2.097 2.097 0.000 ( +0.0% ) 9.78 9.67 +1.2% 1.480 1.481
2500.401 2.164 2.164 0.000 ( +0.0% ) 9.83 9.68 +1.5% 1.288 1.283
2500.5 1.668 1.668 0.000 ( +0.0% ) 15.51 15.24 +1.8% 1.192 1.200
2500.501 1.729 1.729 0.000 ( +0.0% ) 15.53 15.12 +2.7% 1.206 1.205
2500.51 1.071 1.071 0.000 ( +0.0% ) 28.18 27.23 +3.5% 1.494 1.489
2500.511 1.137 1.137 0.000 ( +0.0% ) 27.67 27.07 +2.2% 1.517 1.517
2500.6 2.006 2.006 0.000 ( +0.0% ) 12.45 12.33 +1.0% 1.254 1.260
2500.601 2.076 2.076 0.000 ( +0.0% ) 12.43 12.23 +1.7% 1.275 1.267

@swertz
Copy link
Contributor

swertz commented Feb 10, 2023

+1

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

backport of #40667

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 00a0c00 into cms-sw:CMSSW_12_6_X Feb 14, 2023
@nurfikri89 nurfikri89 deleted the portFrom130XTo126X_PuppiInQGLTagger branch June 7, 2023 18:38
@nurfikri89 nurfikri89 restored the portFrom130XTo126X_PuppiInQGLTagger branch June 7, 2023 18:38
@nurfikri89 nurfikri89 deleted the portFrom130XTo126X_PuppiInQGLTagger branch June 7, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants