Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[126X] The Lorentz Angle Prompt Calibration Loop for Pixel Forward Phase 1 detector #40734

Merged
merged 3 commits into from
Feb 10, 2023

Conversation

tsusa
Copy link
Contributor

@tsusa tsusa commented Feb 9, 2023

PR description:

This PR introduces the Lorentz Angle (LA) Prompt Calibration Loop for the Pixel Forward Phase 1 detector (FPIX). In FPIX, LA is measured using the Minimal Cluster Size method.
The SiPixelLorentzAnglePCLWorker creates 16 2D cluster size x/y vs cot(alpha/beta) histograms and 8x3 magnetic field components histograms. In SiPixelLorentzAnglePCHarvesterMCS the cluster size x/y vs cot(alpha/beta) histograms are used to generate 1D profiles (average cluster size x/y vs cot(alpha/beta)) which are then fit and the values of the cot (alpha/beta) for which the cluster sizes are minimal are determined. The obtained cot(alpha/beta)_min value for z- and z+ side are used to perform fit to determine muH for different rings and panels of the Pixel Forward Phase 1 detector using the formulas:

cot(alpha)_min = vx/vz = (muHBy + muH^2xBzBx)/(1+muH^2Bz^2)
cot(beta)_min = vy/vz = -(muHBx - muH^2xBzBx)/(1+muH^2Bz^2)

PR validation:

runTheMatrix for the new wfs 1052, 1052.1

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of the PR #40664.
Backport is needed for cosmics data taking.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2023

A new Pull Request was created by @tsusa (Tatjana Susa) for CMSSW_12_6_X.

It involves the following packages:

  • CalibTracker/SiPixelLorentzAngle (alca)
  • Calibration/TkAlCaRecoProducers (alca)
  • CondFormats/Common (db, alca)
  • Configuration/AlCa (alca)
  • Configuration/EventContent (operations)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)

@perrotta, @malbouis, @rappoccio, @yuanchao, @bbilin, @tvami, @cmsbuild, @AdrianoDee, @srimanob, @saumyaphor4252, @kskovpen, @ggovi, @sunilUIET, @francescobrivio, @ChrisMisan, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @kpedro88, @argiro, @Martin-Grunewald, @thomreis, @threus, @slomeo, @makortel, @JanFSchulte, @dgulhan, @missirol, @seemasharmafnal, @simonepigazzini, @GiacomoSguazzoni, @rovere, @VinInn, @mroguljic, @ferencek, @tocheng, @mmusich, @mtosi, @fabiocos, @rchatter, @dkotlins, @sameasy, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Feb 9, 2023

test parameters:

  • workflows = 1052.0,1052.1

@mmusich
Copy link
Contributor

mmusich commented Feb 9, 2023

@cmsbuild, please test

@francescobrivio
Copy link
Contributor

backport of #40664

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 9, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bcd06a/30538/summary.html
COMMIT: 8e00de0
CMSSW: CMSSW_12_6_X_2023-02-08-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40734/30538/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3460357
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3460335
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Feb 9, 2023

+1

  • tests pass, master PR is in the IBs

@mmusich
Copy link
Contributor

mmusich commented Feb 10, 2023

@cms-sw/pdmv-l2 @cms-sw/upgrade-l2 kind ping for a review of this ~ verbatim backport of #40664.
The only differences are due to the fact that #40664 piggy-backed on #40661 for some of the new workflow steps, while here they are included directly in the commits proposed.
Please let us know if you agree (as a reminder this would be great to have integrated in time for the CRAFT data-taking later on this year).

@kskovpen
Copy link
Contributor

+pdmv

@srimanob
Copy link
Contributor

+Upgrade

Backport PR.

@tvami
Copy link
Contributor

tvami commented Feb 10, 2023

@cms-sw/orp-l2 we are essentially fully signed

@perrotta
Copy link
Contributor

@mmusich
Copy link
Contributor

mmusich commented Feb 10, 2023

Could you please comment about those differences?

See #40734 (comment)

@perrotta
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 3b733e4 into cms-sw:CMSSW_12_6_X Feb 10, 2023
@tsusa tsusa deleted the fpixLAPCL_126X branch February 14, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants