add a unit Test for OnlineBeamMonitor

[mmusich]

PR description:

Title says it all, prompted by PR #40716.

PR validation:

Run the unit tests: scram b runtests
They are currently failing because of the issue detailed at #39948, but one #40716 is integrated it should solve the issue.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40727/34125

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• DQM/BeamMonitor (dqm, db)

@malbouis, @pmandrik, @emanueleusai, @tvami, @cmsbuild, @saumyaphor4252, @syuvivida, @ggovi, @francescobrivio, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@mmusich, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

please test

• expected to fail, just to show it is able to capture the issue

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-454de8/30522/summary.html
COMMIT: 08591c1
CMSSW: CMSSW_13_0_X_2023-02-08-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40727/30522/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test testOnlineBeamMonitor had ERRORS

Comparison Summary

Summary:

• You potentially added 9 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555852
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555830
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40727/34134

• This PR adds an extra 12KB to repository

[cmsbuild]

Pull request #40727 was updated. @malbouis, @pmandrik, @emanueleusai, @tvami, @cmsbuild, @saumyaphor4252, @syuvivida, @ggovi, @francescobrivio, @micsucmed, @rvenditti can you please check and sign again.

[cmsbuild]

Pull request #40727 was updated. @malbouis, @pmandrik, @emanueleusai, @tvami, @cmsbuild, @saumyaphor4252, @syuvivida, @ggovi, @francescobrivio, @micsucmed, @rvenditti can you please check and sign again.

[francescobrivio]

@mmusich should we trigger tests here given in #40716 it's working fine?

[tvami]

@mmusich should we trigger tests here given in #40716 it's working fine?

I think we can just sign this based on #40716

[mmusich]

should we trigger tests here given in #40716 it's working fine?

actually either you test it together with #40716 or only after that one is merged and an IB with it is available -- otherwise it is expected to fail 😓 (see #40727 (comment)).

----- Begin Fatal Exception 08-Feb-2023 19:17:07 CET-----------------------
An exception of category 'StdException' occurred while
   [0] Processing global begin LuminosityBlock run: 326479 luminosityBlock: 1
   [1] Calling method for module OnlineBeamMonitor/'onlineBeamMonitor'
Exception Message:
A std::exception was thrown.
Parameter with index 0 is out of range.
----- End Fatal Exception -------------------------------------------------

[francescobrivio]

+1

• for reference - see add a unit Test for OnlineBeamMonitor #40727 (comment)

[francescobrivio]

@cmsbuild please test with #40716

• just to have clean tests

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-454de8/30543/summary.html
COMMIT: 0a7d669
CMSSW: CMSSW_13_0_X_2023-02-09-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40727/30543/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• You potentially removed 3 lines from the logs
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555852
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555824
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mmusich]

relval timeout is unrelated.
Now that #40716 is merged this can be merged as well.

[perrotta]

relval timeout is unrelated. Now that #40716 is merged this can be merged as well.

@emanueleusai do you have any objection?

[emanueleusai]

no objections

[emanueleusai]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1

• This PR simply adds a unit test, letting all workflows untouched: therefore it can be merged in 13_0_X before switching the master to 13_1_X, to make it already available also in 13_0_X

[perrotta]

merge