Implement a first draft of the ROCmServices #40642

fwyzard · 2023-01-30T22:48:30Z

PR description:

Implement a first draft of the ROCmService and ROCmMonitoringService.

While the ROCmService is not on par with the CUDAService, it is already usable, especially for the ROCm library tests and as the basis to implement more ROCm utilities.

The commented out code is left as a reminder of the CUDAService features that are still missing.

The PR builds on top of and includes:

Add ROCm utilities and tests, and CUDA fallbacks #40619

PR validation:

The new unit tests pass.

cmsbuild · 2023-01-30T22:56:30Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40642/33945

ERROR: Build errors found during clang-tidy run.

HeterogeneousCore/ROCmServices/src/ROCmService.cc:20:10: error: 'HeterogeneousCore/ROCmUtilities/interface/hipCheck.h' file not found [clang-diagnostic-error]
#include "HeterogeneousCore/ROCmUtilities/interface/hipCheck.h"
         ^
Suppressed 517 warnings (516 in non-user code, 1 with check filters).
--
HeterogeneousCore/ROCmServices/plugins/ROCmMonitoringService.cc:15:10: error: 'HeterogeneousCore/ROCmUtilities/interface/hipCheck.h' file not found [clang-diagnostic-error]
#include "HeterogeneousCore/ROCmUtilities/interface/hipCheck.h"
         ^
Suppressed 548 warnings (547 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

fwyzard · 2023-01-30T23:00:10Z

This PR requires #40619 .

fwyzard · 2023-01-31T16:09:41Z

please test with cms-sw/cmsdist#8273,#40619

fwyzard · 2023-01-31T20:21:16Z

please test

fwyzard · 2023-01-31T20:25:09Z

+heterogeneous

cmsbuild · 2023-02-01T08:16:52Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40642/33987

ERROR: Build errors found during clang-tidy run.

HeterogeneousCore/ROCmServices/src/ROCmService.cc:20:10: error: 'HeterogeneousCore/ROCmUtilities/interface/hipCheck.h' file not found [clang-diagnostic-error]
#include "HeterogeneousCore/ROCmUtilities/interface/hipCheck.h"
         ^
Suppressed 518 warnings (517 in non-user code, 1 with check filters).
--
HeterogeneousCore/ROCmServices/plugins/ROCmMonitoringService.cc:15:10: error: 'HeterogeneousCore/ROCmUtilities/interface/hipCheck.h' file not found [clang-diagnostic-error]
#include "HeterogeneousCore/ROCmUtilities/interface/hipCheck.h"
         ^
Suppressed 549 warnings (548 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

fwyzard · 2023-02-01T08:18:53Z

Ah... so the code checks use the latest IB as-is, without the PRs that have already been merged :-(

fwyzard · 2023-02-01T11:36:23Z

please test

fwyzard · 2023-02-01T11:38:14Z

+heterogeneous

cmsbuild · 2023-02-01T11:48:24Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40642/33991

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File HeterogeneousCore/ROCmServices/BuildFile.xml modified in PR(s): Add a test for ROCm libraries and build rules #40637
- File HeterogeneousCore/ROCmServices/interface/ROCmService.h modified in PR(s): Add a test for ROCm libraries and build rules #40637
- File HeterogeneousCore/ROCmServices/plugins/BuildFile.xml modified in PR(s): Add a test for ROCm libraries and build rules #40637
- File HeterogeneousCore/ROCmServices/plugins/ROCmMonitoringService.cc modified in PR(s): Add a test for ROCm libraries and build rules #40637
- File HeterogeneousCore/ROCmServices/plugins/plugins.cc modified in PR(s): Add a test for ROCm libraries and build rules #40637
- File HeterogeneousCore/ROCmServices/src/ROCmService.cc modified in PR(s): Add a test for ROCm libraries and build rules #40637
- File HeterogeneousCore/ROCmServices/test/BuildFile.xml modified in PR(s): Add a test for ROCm libraries and build rules #40637
- File HeterogeneousCore/ROCmServices/test/testROCmService.cpp modified in PR(s): Add a test for ROCm libraries and build rules #40637
- File HeterogeneousCore/ROCmServices/test/testROCmService.py modified in PR(s): Add a test for ROCm libraries and build rules #40637

cmsbuild · 2023-02-01T11:48:47Z

Pull request #40642 was updated. can you please check and sign again.

cmsbuild · 2023-02-01T16:14:00Z

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f8bc51/30326/summary.html
COMMIT: 4f5ff35
CMSSW: CMSSW_13_0_X_2023-01-31-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40642/30326/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

You potentially added 8 lines to the logs
Reco comparison results: 7 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555495
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3555467
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 211 log files, 162 edm output root files, 49 DQM output files
TriggerResults: no differences found

perrotta · 2023-02-01T17:34:17Z

+1

perrotta · 2023-02-01T17:34:25Z

merge

cmsbuild added this to the CMSSW_13_0_X milestone Jan 30, 2023

cmsbuild added code-checks-pending heterogeneous-pending orp-pending pending-signatures tests-pending labels Jan 30, 2023

fwyzard mentioned this pull request Jan 30, 2023

Implement HIP/ROCm build rules and test packages #40627

Closed

cmsbuild added code-checks-rejected and removed code-checks-pending labels Jan 30, 2023

fwyzard mentioned this pull request Jan 31, 2023

Add a test for ROCm libraries and build rules #40637

Merged

cmsbuild added requires-external tests-started and removed tests-pending labels Jan 31, 2023

fwyzard force-pushed the ROCmService branch from 330aa57 to e26a97b Compare January 31, 2023 20:20

cmsbuild added tests-pending code-checks-pending and removed tests-started requires-external code-checks-rejected labels Jan 31, 2023

cmsbuild added tests-started and removed tests-pending labels Jan 31, 2023

cmsbuild added fully-signed heterogeneous-approved and removed pending-signatures heterogeneous-pending labels Jan 31, 2023

cmsbuild added code-checks-rejected and removed code-checks-pending labels Feb 1, 2023

Implement a first draft of the ROCmService

4f5ff35

fwyzard force-pushed the ROCmService branch from df6d072 to 4f5ff35 Compare February 1, 2023 11:36

cmsbuild added code-checks-pending and removed code-checks-rejected labels Feb 1, 2023

cmsbuild added fully-signed heterogeneous-approved and removed pending-signatures heterogeneous-pending labels Feb 1, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 1, 2023

cmsbuild added tests-rejected and removed tests-started labels Feb 1, 2023

cmsbuild added orp-approved and removed orp-pending labels Feb 1, 2023

cmsbuild merged commit 939817c into cms-sw:master Feb 1, 2023

This was referenced Feb 2, 2023

Custom Run 3 PFScouting NanoAOD #40438

Merged

[Tensorflow] Build with GPU enabled cms-sw/cmsdist#7648

Merged

fwyzard deleted the ROCmService branch February 2, 2023 12:44

cmsbuild mentioned this pull request Feb 2, 2023

Update Tensorflow to version 2.11.0 cms-sw/cmsdist#8258

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement a first draft of the ROCmServices #40642

Implement a first draft of the ROCmServices #40642

fwyzard commented Jan 30, 2023 •

edited

Loading

cmsbuild commented Jan 30, 2023

fwyzard commented Jan 30, 2023

fwyzard commented Jan 31, 2023

fwyzard commented Jan 31, 2023

fwyzard commented Jan 31, 2023

cmsbuild commented Feb 1, 2023

fwyzard commented Feb 1, 2023

fwyzard commented Feb 1, 2023

fwyzard commented Feb 1, 2023

cmsbuild commented Feb 1, 2023

cmsbuild commented Feb 1, 2023

cmsbuild commented Feb 1, 2023

perrotta commented Feb 1, 2023

perrotta commented Feb 1, 2023

Implement a first draft of the ROCmServices #40642

Implement a first draft of the ROCmServices #40642

Conversation

fwyzard commented Jan 30, 2023 • edited Loading

PR description:

PR validation:

cmsbuild commented Jan 30, 2023

fwyzard commented Jan 30, 2023

fwyzard commented Jan 31, 2023

fwyzard commented Jan 31, 2023

fwyzard commented Jan 31, 2023

cmsbuild commented Feb 1, 2023

fwyzard commented Feb 1, 2023

fwyzard commented Feb 1, 2023

fwyzard commented Feb 1, 2023

cmsbuild commented Feb 1, 2023

cmsbuild commented Feb 1, 2023

cmsbuild commented Feb 1, 2023

RelVals-INPUT

Comparison Summary

perrotta commented Feb 1, 2023

perrotta commented Feb 1, 2023

fwyzard commented Jan 30, 2023 •

edited

Loading