Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_6_X] Update data files for DropBoxMetadata tag #40640

Merged

Conversation

saumyaphor4252
Copy link
Contributor

PR description:

Backport of #40522

This PR updates the json files that are used to produce the DropBoxMetada tag. Some of the tags (SiStripBadChannel_PCL_v1_prompt, BeamSpotObjects_PCL_byRun_v1_prompt and BeamSpotObjects_PCL_byLumi_v1_prompt) had pcl synchronization in Prep DB which prevented their upload from Tier0 replays. With this PR those tags are replaced and it also updates a few other ones to have different names between Prod and Prep tags to avoid such a case in Prep DB inthe future.

The difference between the new DMD tag produced with the changes introduced here and the previous one can be seen in https://cern.ch/go/LC9S

The new DMD tag has been included in the 126X_dataRun3_Express_Queue and will be picked up when a new Express GT is created.

PR validation:

  • created a Candidate GT by queueing the new tag to 126X_dataRun3_Express_Queue
  • ran the RTM workflow 1001.3 with the candidate GT from above

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #40522

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 30, 2023

A new Pull Request was created by @saumyaphor4252 (Saumya Phor) for CMSSW_12_6_X.

It involves the following packages:

  • CondFormats/Common (db, alca)

@malbouis, @yuanchao, @cmsbuild, @saumyaphor4252, @ggovi, @tvami, @ChrisMisan, @francescobrivio can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@saumyaphor4252
Copy link
Contributor Author

backport of #40522

@saumyaphor4252
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c236ff/30257/summary.html
COMMIT: 738526a
CMSSW: CMSSW_12_6_X_2023-01-30-1100/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40640/30257/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 2057 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3458651
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3458626
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 206 log files, 158 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@malbouis
Copy link
Contributor

malbouis commented Jan 31, 2023

+1

  • PR according to description
  • tests pass

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

  • Intended for the initial data taking of 2023 (MWGRs...)

@cmsbuild cmsbuild merged commit 3dee19c into cms-sw:CMSSW_12_6_X Jan 31, 2023
@saumyaphor4252 saumyaphor4252 deleted the alca-updateDMDtags-126X branch October 13, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants