Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JeProfService to allow dumping of Jemalloc heap profiles during running. #40624

Merged
merged 12 commits into from
Feb 3, 2023
Merged

Add JeProfService to allow dumping of Jemalloc heap profiles during running. #40624

merged 12 commits into from
Feb 3, 2023

Conversation

gartung
Copy link
Member

@gartung gartung commented Jan 26, 2023 •
edited
Loading

Add JeProfService to allow dumping of Jemalloc heap profiles during running.

@cmsbuild cmsbuild added this to the CMSSW_13_0_X milestone Jan 26, 2023
@gartung gartung changed the title Add JeProfService to allow dumping of Jemalloc heap profiles during running. WIP: Add JeProfService to allow dumping of Jemalloc heap profiles during running. Jan 26, 2023
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40624/33900

  • This PR adds an extra 8KB to repository

@gartung
Copy link
Member Author

gartung commented Jan 26, 2023

hold

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

  • IgTools/IgProf (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@gartung gartung force-pushed the gartung-jemalloc-prof-service branch from b1b9b89 to 723fafe Compare January 26, 2023 17:34
@cmsbuild
Copy link
Contributor

Pull request #40624 was updated. @cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please check and sign again.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40624/33902

  • This PR adds an extra 8KB to repository

@makortel
Copy link
Contributor

hold

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @makortel
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@cmsbuild cmsbuild added the hold label Jan 26, 2023
@gartung gartung force-pushed the gartung-jemalloc-prof-service branch from 723fafe to fd2d581 Compare January 26, 2023 17:54
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4467b0/30229/summary.html
COMMIT: db1fc24
CMSSW: CMSSW_13_0_X_2023-01-28-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40624/30229/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 12 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555495
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555467
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@cmsbuild cmsbuild mentioned this pull request Jan 29, 2023
Merged
@gartung gartung changed the title WIP: Add JeProfService to allow dumping of Jemalloc heap profiles during running. Add JeProfService to allow dumping of Jemalloc heap profiles during running. Jan 30, 2023
@gartung
Copy link
Member Author

gartung commented Jan 30, 2023

@makortel This is ready to be merged. Can you please unhold it.

@makortel
Copy link
Contributor

unhold

@cmsbuild cmsbuild removed the hold label Jan 30, 2023
@makortel makortel mentioned this pull request Jan 30, 2023
Merged
@makortel
Copy link
Contributor

The package is added for bot in cms-sw/cms-bot#1929

@makortel
Copy link
Contributor

makortel commented Feb 2, 2023

ping bot

@makortel
Copy link
Contributor

makortel commented Feb 2, 2023

+1

@perrotta
Copy link
Contributor

perrotta commented Feb 3, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 3, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit d86e31d into cms-sw:master Feb 3, 2023
This was referenced Feb 3, 2023
Merged
Merged
Closed
@gartung gartung deleted the gartung-jemalloc-prof-service branch March 2, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makortel makortel makortel left review comments

Assignees
No one assigned
Labels
code-checks-approved core-approved fully-signed operations-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_13_0_X
Development

Successfully merging this pull request may close these issues.
5 participants
@gartung @cmsbuild @makortel @smuzaffar @perrotta