-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RECONSTRUCTION][CLANG] Fix clang llvm14 warnings #40611
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40611/33874
|
A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for master. It involves the following packages:
@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
RecoPixelVertexing/PixelTriplets/plugins/PixelTripletLargeTipGenerator.cc
Outdated
Show resolved
Hide resolved
@@ -73,7 +73,7 @@ MultiGaussianState<N> CloseComponentsMerger<N>::merge(const MultiState& mgs) con | |||
comp.push_back(ori[toMerge.top()]); | |||
comp.push_back(ori[ii]); | |||
active[ii] = false; | |||
while ((!toMerge.empty()) & (!active[toMerge.top()])) { | |||
while ((!toMerge.empty()) && (!active[toMerge.top()])) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess here it should be a logical &&
to avoid out of bound reads
@VinInn please confirm/check
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-71c36a/30162/summary.html Comparison SummarySummary:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40611/33910
|
Pull request #40611 was updated. @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again. |
Fix clang llvm14 warnings Keep intended bitwise operator Keep intended bitwise operator
2521193
to
26664b3
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40611/33949
|
Pull request #40611 was updated. @cmsbuild, @mandrenguyen, @clacaputo can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-71c36a/30378/summary.html Comparison SummarySummary:
|
+reconstruction |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Hello,
This PR fixes the warnings due to unused but set variables and the use of bitwise '|' or '&' with boolean operands that we get with LLVM14 in CLANG IBs for the reconstruction modules.
Thanks,
Andrea.