get rid of Phase2TrackerRecHit1D::CluRef

[mmusich]

PR description:

In #40323 Phase2TrackerRecHit1D::ClusterRef had to be introduced in order to resolve this line:

cmssw/CommonTools/RecoAlgos/src/ClusterStorer.cc

Line 108 in 79e79bd

typedef typename std::vector<ClusterHitRecord<typename HitType::ClusterRef> >::iterator RIT;

correctly when HitType is a Phase2TrackerRecHit1D.
This PR drops the preexisting typedef Phase2TrackerRecHit1D::CluRef in favour of the new one, making the nomenclature uniform among different tracking rechit types.

PR validation:

cmssw compiles

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

[mmusich]

test parameters:

• workflow = 20834.9, 20818.9
• relvals_opt= -w upgrade

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40601/33857

• This PR adds an extra 24KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

• DataFormats/TrackerRecHit2D (reconstruction)
• RecoLocalTracker/SubCollectionProducers (reconstruction)
• SimTracker/TrackerHitAssociation (simulation)

@cmsbuild, @civanch, @mandrenguyen, @clacaputo, @mdhildreth can you please review it and eventually sign? Thanks.
@echabert, @felicepantaleo, @VourMa, @swertz, @missirol, @GiacomoSguazzoni, @yduhm, @robervalwalsh, @JanFSchulte, @rovere, @VinInn, @alesaggio, @gpetruc, @wmtford, @mtosi, @gbenelli, @mmusich, @threus, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-165f79/30141/summary.html
COMMIT: 3755edf
CMSSW: CMSSW_13_0_X_2023-01-23-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40601/30141/install.sh to create a dev area with all the needed externals and cmssw changes.

• DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3747285
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3747260
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
• Checked 221 log files, 170 edm output root files, 51 DQM output files
• TriggerResults: no differences found

[mmusich]

test parameters:

• workflow = 20834.9
• relvals_opt= -w upgrade

[mmusich]

DAS Queries: The DAS query tests failed, see the summary page for details.

looks like DAS queries are failing for wf 20818.9: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-165f79/30141/dasqueries/failed_workflows.log

Let's re-try without it.

[mmusich]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-165f79/30159/summary.html
COMMIT: 3755edf
CMSSW: CMSSW_13_0_X_2023-01-24-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40601/30159/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 50
• DQMHistoTests: Total histograms compared: 3651390
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3651365
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 49 files compared)
• Checked 216 log files, 166 edm output root files, 50 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+reconstruction
Technical PR. No change to reco.

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1