Simplify pixel typedefs

[fwyzard]

PR description:

Simplify typedefs and clean up comments in legacy modules.

Make type aliases more consistent in SoA modules: use consistently OnHost and OnDevice instead of OnCPU and OnGPU.

PR validation:

None.

[fwyzard]

please test

[fwyzard]

@nothingface0 @AdrianoDee @borzari FYI

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40565/33799

ERROR: Build errors found during clang-tidy run.

RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitConverter.cc:253:43: error: use of undeclared identifier 'cpeName_' [clang-diagnostic-error]
    LogDebug("SiPixelRecHitConverter") << cpeName_ << " converted " << numberOfClusters
                                          ^
Suppressed 1402 warnings (1401 in non-user code, 1 with check filters).
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:129: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40565/33800

• This PR adds an extra 24KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File RecoLocalTracker/SiPixelRecHits/plugins/SiPixelRecHitFromCUDA.cc modified in PR(s): New Heterogeneous Memory Pool #37952
  • File RecoPixelVertexing/PixelTriplets/plugins/CAHitNtupletGeneratorOnGPU.cc modified in PR(s): New Heterogeneous Memory Pool #37952

[cmsbuild]

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

• RecoLocalTracker/SiPixelRecHits (reconstruction)
• RecoPixelVertexing/PixelTriplets (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@mtosi, @VourMa, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @mroguljic, @missirol, @dkotlins, @ferencek, @gpetruc, @mmusich, @threus, @dgulhan, @tvami this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[mmusich]

before I trigger unwanted tests, is there any particular reason to hold on here?

[fwyzard]

please test

[fwyzard]

no, it was just too early and before a coffee...

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-bcfab9/30082/summary.html
COMMIT: fb0fceb
CMSSW: CMSSW_13_0_X_2023-01-19-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40565/30082/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555479
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555451
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mandrenguyen]

+reconstruction
No changes to comparisons. Code cleanup.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1