check size of collection at BX=0 before getting the product

[vlimant]

PR description:

as reported in ##40494 the size of the collection should be checked before getting any items.

PR validation:

I don't know what workflows are meant for NANO validation in 12.4, so I'll use the PR validation test

[cmsbuild]

A new Pull Request was created by @vlimant (vlimant) for CMSSW_12_4_X.

It involves the following packages:

• PhysicsTools/NanoAOD (xpog)

@cmsbuild, @swertz, @vlimant can you please review it and eventually sign? Thanks.
@gpetruc this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[vlimant]

please test

[missirol]

I don't think this is not the right fix, as wordp-> will fail if wordp remains nullptr.

cmssw/PhysicsTools/NanoAOD/plugins/L1TriggerResultsConverter.cc

Line 153 in c628e55

bool result = wordp->at(index);

I suggest to close in favour of #40528.

[vlimant]

please close

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-abaf56/30002/summary.html
COMMIT: 15ad701
CMSSW: CMSSW_12_4_X_2023-01-15-0000/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40527/30002/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 51
• DQMHistoTests: Total histograms compared: 3766083
• DQMHistoTests: Total failures: 13
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 3766047
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 50 files compared)
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 212 log files, 167 edm output root files, 51 DQM output files
• TriggerResults: no differences found