-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding first version of electronics id class for HGCAL #40504
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40504/33701
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40504/33709
|
A new Pull Request was created by @pfs (Pedro Silva) for master. It involves the following packages:
@cmsbuild, @AdrianoDee, @srimanob, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-98692f/29975/summary.html Comparison SummarySummary:
|
+1 |
+Upgrade FYI @cms-sw/hcal-dpg-l2 in case you have a comment. |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
When decoding or emulating realistic DIGI it may beneficial to include an intermediate Electronics ID.
This PR introduces such class to enable the developments on the logical mapping of HGCAL and on the raw data unpacker which are on-going. The class is a simple wrapper of a 32b word. The contents of which correspond to the following table/counting of entities.
PR validation:
A test unit is included in the PR and has been used to check the class holds and decodes the required values.
It can be run with