Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update L1Menu tag in data RelVal GTs and 2022/2023/2024, Phase2 MC GTs #40501

Merged
merged 1 commit into from
Jan 15, 2023
Merged

Update L1Menu tag in data RelVal GTs and 2022/2023/2024, Phase2 MC GTs #40501

merged 1 commit into from
Jan 15, 2023

Conversation

saumyaphor4252
Copy link
Contributor

PR description:

This PR updates the following Run3 GTs

  • HLT RelVal and offline RelVal data GTs
  • 2022, 2023, 2024 and Phase2 MC GTs

with the latest L1 Menu tag(v1_4_0), i.e. L1Menu_Collisions2022_v1_4_0-d1_xml as requested in this CMSTalk post [1].

[1] https://cms-talk.web.cern.ch/t/run-3-gt-update-of-the-l1-menu-tag-v1-4-0-in-run-3-mc-gts-and-run-3-data-relvals-gts/19165

GT differences:

PR validation:

Successfully tested with:
runTheMatrix.py -l 139.001,7.23,11634.0,12034.0,12834.0,312.0 -j10 --ibeos
which consume the auto:run3_hlt_relval, auto:run3_data_relval, auto:phase1_2022_cosmics, auto:phase1_2022_realistic, auto:phase1_2022_design, auto:phase1_2024_realistic, auto:phase1_2022_realistic_hi keys.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport.
A backport to 12_6_X with only data RelVal GTs will be opened soon.

@cmsbuild cmsbuild added this to the CMSSW_13_0_X milestone Jan 13, 2023
@saumyaphor4252
Copy link
Contributor Author

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40501/33695

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @saumyaphor4252 (Saumya Phor) for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@malbouis, @yuanchao, @saumyaphor4252, @francescobrivio, @ChrisMisan, @tvami can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@saumyaphor4252 saumyaphor4252 mentioned this pull request Jan 13, 2023
Merged
@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53c461/29964/summary.html
COMMIT: 8bfd912
CMSSW: CMSSW_13_0_X_2023-01-12-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40501/29964/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555538
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555507
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@ChrisMisan
Copy link
Contributor

+alca

  • no differences in comparison

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit da3afb9 into cms-sw:master Jan 15, 2023
@saumyaphor4252 saumyaphor4252 deleted the alca-L1menuTagUpdate_MC_RelVal_GTs branch October 13, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-approved code-checks-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_13_0_X
Development

Successfully merging this pull request may close these issues.
4 participants
@saumyaphor4252 @cmsbuild @ChrisMisan @perrotta