Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ECAL : DB PayloadInspector modification #40476

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

depasse
Copy link
Contributor

@depasse depasse commented Jan 11, 2023

PR description:

ECAL : DB PayloadInspector : modification of limits for display of EcalPedestals plots (due to noise increase with integrated luminosity)

PR validation:

Tested in local with CondCore/Utilities/getPayloadData.py : Json file produced on a recent iov

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40476/33649

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @depasse for master.

It involves the following packages:

  • CondCore/EcalPlugins (db)

@malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@rchatter, @simonepigazzini, @mmusich, @thomreis, @argiro this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@tvami
Copy link
Contributor

tvami commented Jan 11, 2023

hi @depasse can you please just delete the commented out lines? (and then squash that commit into the original one)

@tvami
Copy link
Contributor

tvami commented Jan 11, 2023

@depasse please also squash the two commits into one (let me know if you need instructions on how to do that)

@depasse
Copy link
Contributor Author

depasse commented Jan 11, 2023

Yes I need. I suppose I must go to the commits tab but after ?

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40476/33655

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #40476 was updated. @malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please check and sign again.

…alPedestals plots (due to noise increase with integrated luminosity)
@tvami
Copy link
Contributor

tvami commented Jan 11, 2023

@cmsbuild , please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40476/33656

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

Pull request #40476 was updated. @ggovi, @malbouis, @tvami, @saumyaphor4252, @francescobrivio can you please check and sign again.

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18811c/29914/summary.html
COMMIT: 7f8b0e7
CMSSW: CMSSW_13_0_X_2023-01-11-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40476/29914/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
140.01 step 3
140.03 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555538
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555513
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Jan 11, 2023

+db

  • tests pass

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants