-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECAL : DB PayloadInspector modification #40476
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40476/33649
|
A new Pull Request was created by @depasse for master. It involves the following packages:
@malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
hi @depasse can you please just delete the commented out lines? (and then squash that commit into the original one) |
@depasse please also squash the two commits into one (let me know if you need instructions on how to do that) |
Yes I need. I suppose I must go to the commits tab but after ? |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40476/33655
|
Pull request #40476 was updated. @malbouis, @cmsbuild, @saumyaphor4252, @ggovi, @francescobrivio, @tvami can you please check and sign again. |
…alPedestals plots (due to noise increase with integrated luminosity)
ee86e4a
to
7f8b0e7
Compare
@cmsbuild , please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40476/33656
|
Pull request #40476 was updated. @ggovi, @malbouis, @tvami, @saumyaphor4252, @francescobrivio can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-18811c/29914/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
+db
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
ECAL : DB PayloadInspector : modification of limits for display of EcalPedestals plots (due to noise increase with integrated luminosity)
PR validation:
Tested in local with CondCore/Utilities/getPayloadData.py : Json file produced on a recent iov