Removed legacy EDAnalyzer interface

[Dr15Jones]

PR description:

• All uses of edm::EDAnalyzer should have already been removed from CMSSW. This now removes that interface from the framework.

PR validation:

Framework code compiles.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40466/33637

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/Framework/interface/Frameworkfwd.h modified in PR(s): Removed use of edm::EDFilter & edm::EDProducer #39710
  • File FWCore/Framework/src/WorkerT.cc modified in PR(s): Removed use of edm::EDFilter & edm::EDProducer #39710
  • File FWCore/ParameterSet/interface/ParameterSetDescriptionFillerBase.h modified in PR(s): Removed use of edm::EDFilter & edm::EDProducer #39710

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• FWCore/Framework (core)
• FWCore/MessageService (core)
• FWCore/ParameterSet (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ffc456/29881/summary.html
COMMIT: 5d260c3
CMSSW: CMSSW_13_0_X_2023-01-10-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40466/29881/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555538
• DQMHistoTests: Total failures: 154
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555362
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[Dr15Jones]

please test

[Dr15Jones]

I put back the EDAnalyzer.h file with an embedded #error to match what was done with EDProducer.h and EDFilter.h. I then added that header to the list of headers to ignore when doing header consistency checks.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40466/33663

• This PR adds an extra 32KB to repository

[cmsbuild]

Pull request #40466 was updated. @makortel, @smuzaffar, @Dr15Jones can you please check and sign again.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ffc456/29919/summary.html
COMMIT: 870fdfa
CMSSW: CMSSW_13_0_X_2023-01-11-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40466/29919/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @smuzaffar Disable header consistency checks for EDFilter.h EDProducer.h #40474
• @francescobrivio Mask more old b-taggers for run3_common #40464
• @smuzaffar [llvm14][Sim] Fixed set but not used variables warnings #40312
• @francescobrivio Update GTs for 2023 #40445
• @swertz Remove all nanoV10 workflows #40475

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ffc456/29919/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ffc456/29919/git-merge-result

Comparison Summary

There are some workflows for which there are errors in the baseline:
140.01 step 3
140.03 step 3
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

• No significant changes to the logs found
• Reco comparison results: 2740 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3555538
• DQMHistoTests: Total failures: 0
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3555516
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 211 log files, 162 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[makortel]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[makortel]

release-note: This PR is the final step in removing the support for legacy EDModules. Any code using legacy EDModule base classes outside CMSSW needs to be migrated to one of the base classes supporting multithreading. Please see documentation in https://twiki.cern.ch/twiki/bin/view/CMSPublic/FWMultithreadedFrameworkModuleTypes.

[perrotta]

+1