Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask more old b-taggers for run3_common #40464

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Mask more old b-taggers for run3_common #40464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions PhysicsTools/PatAlgos/python/slimming/applySubstructure_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,13 @@ def applySubstructure( process, postfix="" ) :
groomedFatJets=cms.InputTag('ak8PFJetsPuppiSoftDrop') # needed for subjet flavor clustering
)

from Configuration.Eras.Modifier_run3_common_cff import run3_common
run3_common.toModify(process.patJetsAK8PFPuppiSoftDropSubjets,
discriminatorSources = cms.VInputTag(
cms.InputTag("pfDeepCSVJetTagsAK8PFPuppiSoftDropSubjets","probb"),
cms.InputTag("pfDeepCSVJetTagsAK8PFPuppiSoftDropSubjets","probbb")
)
)

# add groomed ECFs and N-subjettiness to soft dropped pat::Jets for fat jets and subjets
process.load('RecoJets.JetProducers.ECF_cff')
Expand Down Expand Up @@ -131,6 +138,16 @@ def applySubstructure( process, postfix="" ) :
getattr(process,"selectedPatJetsAK8Puppi"+postfix).cutLoose = cms.string("pt > 30")
getattr(process,"selectedPatJetsAK8Puppi"+postfix).nLoose = cms.uint32(3)

from Configuration.Eras.Modifier_run3_common_cff import run3_common
run3_common.toModify(process.patJetsAK8Puppi,
discriminatorSources = cms.VInputTag(
cms.InputTag("pfDeepCSVJetTagsAK8Puppi","probb"),
cms.InputTag("pfDeepCSVJetTagsAK8Puppi","probc"),
cms.InputTag("pfDeepCSVJetTagsAK8Puppi","probudsg"),
cms.InputTag("pfDeepCSVJetTagsAK8Puppi","probbb")
)
)

from RecoJets.JetAssociationProducers.j2tParametersVX_cfi import j2tParametersVX
addToProcessAndTask('ak8PFJetsPuppiTracksAssociatorAtVertex'+postfix, cms.EDProducer("JetTracksAssociatorAtVertex",
j2tParametersVX.clone( coneSize = cms.double(0.8) ),
Expand Down
8 changes: 8 additions & 0 deletions RecoBTag/SoftLepton/python/SoftLeptonByMVAComputers_cff.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,3 +45,11 @@
softPFMuonCommon,
ipSign = cms.string("positive")
)

from Configuration.Eras.Modifier_run3_common_cff import run3_common
run3_common.toModify(softPFElectronComputer,
useCondDB = cms.bool(False),
)
run3_common.toModify(softPFMuonComputer,
useCondDB = cms.bool(False),
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a suggestion, not a strict requirement (coming from BTV Reco):
To apply these changes to all the Computers which might be called somewhere, these modifications could be extended to also touch positiveSoftPFMuonComputer,negativeSoftPFMuonComputer,positiveSoftPFElectronComputer,positiveSoftPFElectronComputer in the exact same way. All six producers here use the same PSet, so they could be changed now as well in one go to also set useCondDB = cms.bool(False), even if these additional four producers are not responsible for any errors in the tests currently.
Otherwise the changes look fine.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AnnikaStein thanks for the suggestion!
Sure I can extend the change to the other producers, but I have one question:
all of them are using the same PSets (softPF[Muon|Electron]Common), so wouldn't it be easier to modify directly the "Common" PSets? Or that's too risky because the Common ones might be imported somewhere else?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @francescobrivio
I totally agree it would be easier. My initial concern was exactly what you mentioned, with the risk that it might be imported somewhere else. But actually, using the cmssdt lxr and github search, I only found some place in HLT for Phase-2, where this PSet is defined as well, but I found no place where it gets directly imported. From that point of view, it should be safe to follow up with changing the PSet itself in another PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @AnnikaStein given that from that on it's less of an AlCaDB business, I'm wondering if you could submit the PR? (If yes, please also tag us, just that we can follow it was done)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @tvami
Ok, will do!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!