-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guard TriggerRatesMonitor
against unavailable trigger paths
#40439
guard TriggerRatesMonitor
against unavailable trigger paths
#40439
Conversation
auto const triggerIdx = histograms.hltConfig.triggerIndex(path); | ||
if (triggerIdx < nTriggers) | ||
histograms.datasets[i].push_back(triggerIdx); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This (i.e. the check on < nTriggers
) is the change to fix the error reported in CMSHLT-2577. A similar check can be found in
cmssw/HLTrigger/JSONMonitoring/plugins/HLTriggerJSONMonitoring.cc
Lines 230 to 232 in 7e6539b
auto const index = rundata->hltConfig.triggerIndex(datasetPathName); | |
if (index < triggerNamesSize) | |
dataset.push_back(index); |
The rest of the changes in this PR is about adding a few checks, plus minor cleanup.
auto const triggerIdx = histograms.hltConfig.triggerIndex(path); | ||
if (triggerIdx < nTriggers) | ||
histograms.streams[i].push_back(triggerIdx); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This (i.e. the check on < nTriggers
) is the change to fix the error reported in CMSHLT-2577. A similar check can be found in
cmssw/HLTrigger/JSONMonitoring/plugins/HLTriggerJSONMonitoring.cc
Lines 230 to 232 in 7e6539b
auto const index = rundata->hltConfig.triggerIndex(datasetPathName); | |
if (index < triggerNamesSize) | |
dataset.push_back(index); |
The rest of the changes in this PR is about adding a few checks, plus minor cleanup.
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40439/33579
|
A new Pull Request was created by @missirol (Marino Missiroli) for master. It involves the following packages:
@Martin-Grunewald, @emanueleusai, @ahmad3213, @cmsbuild, @missirol, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
||
unsigned int datasets = histograms.hltConfig.datasetNames().size(); | ||
unsigned int const datasets = histograms.hltConfig.datasetNames().size(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps, in analogy to nTriggers
here above, you can profit of this PR and rename this size as nDatasets
: as such you'd also aviod giving tha same name to a (vector) class member and to this size, which can be confusing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion. This is now in 94344d9. Diff of the latest changes:
https://github.com/cms-sw/cmssw/compare/cc9a15215b3aaebe6bb5ea036fa894e0bcf77972..94344d9f41472e1fe769a931001fdf20d501c1a0
Unless you really want to test this PR standalpne, I don't see the reason to test it twice |
The 2nd test would just be a confirmation that this PR could be merged before #40334. If this is obvious to all, I'm happy not to test twice. |
cc9a152
to
94344d9
Compare
test parameters:
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40439/33586
|
Pull request #40439 was updated. @emanueleusai, @ahmad3213, @Martin-Grunewald, @missirol, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please check and sign again. |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5dc01f/29816/summary.html Comparison SummarySummary:
|
+1
|
+hlt
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
test parameters: |
+1 |
PR description:
This PR includes a small improvement to the plugin
TriggerRatesMonitor
, in order to support configurations using it with a subset of Paths of a HLT menu. Details on the original issue can be found in CMSHLT-2577.Minor unrelated changes to the plugin in question are also included.
No changes expected in the outputs of PR tests.
PR validation:
Private tests, e.g.
If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:
N/A