Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore DQM live clients process names #40421

Merged
merged 2 commits into from
Jan 7, 2023

Conversation

francescobrivio
Copy link
Contributor

PR description:

This PR restores the DQM live clients process names which were erroneously all changed to BeamMonitor in #39988.
Clients fixed:

  • beam_dqm_sourceclient-live_cfg.py
  • beamfake_dqm_sourceclient-live_cfg.py
  • beamhlt_dqm_sourceclient-live_cfg.py
  • beamhltfake_dqm_sourceclient-live_cfg.py
  • beampixel_dqm_sourceclient-live_cfg.py
  • physics_dqm_sourceclient-live_cfg.py
  • pixel_dqm_sourceclient-live_cfg.py
  • pixellumi_dqm_sourceclient-live_cfg.py

I profit of this PR to also remove the sistriplas_dqm_sourceclient-live_cfg.py client which has not been used since Run 1 as suggested in this comment (FYI @cms-sw/tracking-pog-l2).

PR validation:

None - as this is a simple bugfix of names

Backport:

Not a backport. No backport needed.

@francescobrivio
Copy link
Contributor Author

type bug-fix

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 3, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40421/33549

  • This PR adds an extra 28KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 3, 2023

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

  • DQM/Integration (dqm)

@emanueleusai, @ahmad3213, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks.
@threus, @batinkov, @battibass this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 3, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53d766/29790/summary.html
COMMIT: b6087e1
CMSSW: CMSSW_13_0_X_2023-01-03-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40421/29790/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53d766/29790/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-53d766/29790/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3555748
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3555726
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 211 log files, 162 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 7, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Jan 7, 2023

+1

@cmsbuild cmsbuild merged commit c3ab492 into cms-sw:master Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants