[DQM] [CLANG] Fixed unused-but-set-variable warnings #40400

smuzaffar · 2022-12-22T10:30:58Z

This PR fixes unused-but-set-variable warnings which we get with LLVM14 in CLANG IBS

cmsbuild · 2022-12-22T10:41:33Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40400/33523

This PR adds an extra 124KB to repository

cmsbuild · 2022-12-22T10:41:55Z

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

DPGAnalysis/HcalTools (dqm)
DQMOffline/Hcal (dqm)
Validation/HcalRecHits (dqm)
Validation/RecoEgamma (dqm)

@emanueleusai, @ahmad3213, @cmsbuild, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks.
@bsunanda, @rociovilar, @abdoulline, @missirol, @hatakeyamak this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

smuzaffar · 2022-12-28T12:41:53Z

please test

cmsbuild · 2022-12-28T16:44:56Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f882fc/29773/summary.html
COMMIT: f411790
CMSSW: CMSSW_13_0_X_2022-12-28-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40400/29773/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 33 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555748
DQMHistoTests: Total failures: 1203
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3554523
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 211 log files, 162 edm output root files, 49 DQM output files
TriggerResults: no differences found

emanueleusai · 2023-01-07T04:21:21Z

+1

technical PR
changes in DQM plots not related to this PR

cmsbuild · 2023-01-07T04:21:43Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2023-01-07T13:46:08Z

Validation/HcalRecHits/src/HcalRecHitsValidation.cc

        nrechitsCone++;

-        HcalCone += en;


This shouldn't have been removed. In fact, this is used to fill the histo below, now empty (i.e. filled with only zero's):

ah my bad @perrotta , thanks for catching this. I have added this back

perrotta · 2023-01-07T13:49:42Z

DQMOffline/Hcal/src/HcalRecHitsAnalyzer.cc

@@ -613,27 +608,24 @@ void HcalRecHitsAnalyzer::analyze(edm::Event const &ev, edm::EventSetup const &i
  //===========================================================================
  // IN ALL other CASES : ieta-iphi maps
  //===========================================================================
-
+  /*


Since you are removing the lines were eEcal , eEcalB , eEcalE are filled. you should then also remove all the lines that you have commented out, betweem L611 and L628

thanks @perrotta , done

perrotta · 2023-01-07T13:50:55Z

changes in DQM plots not related to this PR

Not really, see #40400 (comment)

perrotta · 2023-01-10T10:02:34Z

@smuzaffar , just in case you did not notice the comments above

cmsbuild · 2023-01-10T10:22:48Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40400/33633

This PR adds an extra 24KB to repository

cmsbuild · 2023-01-10T10:23:11Z

Pull request #40400 was updated. @emanueleusai, @ahmad3213, @cmsbuild, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please check and sign again.

smuzaffar · 2023-01-10T10:24:53Z

please test

cmsbuild · 2023-01-10T14:07:28Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f882fc/29877/summary.html
COMMIT: 24ee074
CMSSW: CMSSW_13_0_X_2023-01-09-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40400/29877/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 9 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3555538
DQMHistoTests: Total failures: 157
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3555359
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
Checked 211 log files, 162 edm output root files, 49 DQM output files
TriggerResults: no differences found

emanueleusai · 2023-01-13T04:55:27Z

+1

cmsbuild · 2023-01-13T04:55:54Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2023-01-13T06:59:19Z

+1

smuzaffar added 2 commits December 22, 2022 11:26

[DQM] [CLANG] Fixed unused-but-set-variable warnings

d185a71

apply code format

f411790

cmsbuild added this to the CMSSW_13_0_X milestone Dec 22, 2022

cmsbuild added code-checks-pending dqm-pending orp-pending pending-signatures tests-pending labels Dec 22, 2022

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 22, 2022

cmsbuild added tests-started and removed tests-pending labels Dec 28, 2022

cmsbuild added tests-approved and removed tests-started labels Dec 28, 2022

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jan 7, 2023

perrotta reviewed Jan 7, 2023

View reviewed changes

smuzaffar added 2 commits January 10, 2023 11:14

removing commented out code for deleted variables

d706b4e

added back the code which was mistakenly deleted

24ee074

cmsbuild removed the dqm-approved label Jan 10, 2023

cmsbuild added code-checks-pending dqm-pending pending-signatures tests-pending and removed fully-signed tests-approved code-checks-approved labels Jan 10, 2023

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 10, 2023

cmsbuild added tests-started and removed tests-pending labels Jan 10, 2023

cmsbuild added tests-approved and removed tests-started labels Jan 10, 2023

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Jan 13, 2023

cmsbuild added orp-approved and removed orp-pending labels Jan 13, 2023

cmsbuild merged commit a90dbf4 into cms-sw:master Jan 13, 2023

This was referenced Jan 13, 2023

[ROOT626] Root update v6 26 00 patches cms-sw/cmsdist#8248

Closed

[ROOT6] Updated root to tip of branch master cms-sw/cmsdist#8247

Merged

aandvalenzuela mentioned this pull request Jan 13, 2023

[DQM] [CLANG] Fixed unused-but-set-variable warnings #40513

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DQM] [CLANG] Fixed unused-but-set-variable warnings #40400

[DQM] [CLANG] Fixed unused-but-set-variable warnings #40400

smuzaffar commented Dec 22, 2022

cmsbuild commented Dec 22, 2022

cmsbuild commented Dec 22, 2022

smuzaffar commented Dec 28, 2022

cmsbuild commented Dec 28, 2022

emanueleusai commented Jan 7, 2023

cmsbuild commented Jan 7, 2023

perrotta Jan 7, 2023 •

edited

Loading

smuzaffar Jan 10, 2023

perrotta Jan 7, 2023

smuzaffar Jan 10, 2023

perrotta commented Jan 7, 2023

perrotta commented Jan 10, 2023

cmsbuild commented Jan 10, 2023

cmsbuild commented Jan 10, 2023

smuzaffar commented Jan 10, 2023

cmsbuild commented Jan 10, 2023

emanueleusai commented Jan 13, 2023

cmsbuild commented Jan 13, 2023

perrotta commented Jan 13, 2023

[DQM] [CLANG] Fixed unused-but-set-variable warnings #40400

[DQM] [CLANG] Fixed unused-but-set-variable warnings #40400

Conversation

smuzaffar commented Dec 22, 2022

cmsbuild commented Dec 22, 2022

cmsbuild commented Dec 22, 2022

smuzaffar commented Dec 28, 2022

cmsbuild commented Dec 28, 2022

Comparison Summary

emanueleusai commented Jan 7, 2023

cmsbuild commented Jan 7, 2023

perrotta Jan 7, 2023 • edited Loading

Choose a reason for hiding this comment

smuzaffar Jan 10, 2023

Choose a reason for hiding this comment

perrotta Jan 7, 2023

Choose a reason for hiding this comment

smuzaffar Jan 10, 2023

Choose a reason for hiding this comment

perrotta commented Jan 7, 2023

perrotta commented Jan 10, 2023

cmsbuild commented Jan 10, 2023

cmsbuild commented Jan 10, 2023

smuzaffar commented Jan 10, 2023

cmsbuild commented Jan 10, 2023

Comparison Summary

emanueleusai commented Jan 13, 2023

cmsbuild commented Jan 13, 2023

perrotta commented Jan 13, 2023

perrotta Jan 7, 2023 •

edited

Loading