-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert change of vertex smearing for 2022 HI , 2023 and 2024 relvals #40238
Conversation
A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_12_4_X. It involves the following packages:
@bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
type bug-fix |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-240f7a/29459/summary.html Comparison SummarySummary:
|
Now as expected the transverse impact parameter w.r.t beamspot makes sense again in wf 12434.0 |
@cms-sw/upgrade-l2 @cms-sw/pdmv-l2 please have a look urgently, this is needed to restore the consistency of the >= 2022 relvals. |
+Upgrade |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
@cms-sw/orp-l2 please clarify the intentions on this PR, which is a mandatory bug-fix. |
@mmusich should there be a master branch version of this PR? I don't see it. |
no, this fixes a mistake that was done exclusively in this branch, see please discussion at #39019 (comment) |
+1 Fixing bug in one branch only. |
PR description:
title says it all, address #39019 (comment)
PR validation:
none.
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A