[12_6_X] Nano: fix and additions to collection matching, remove cross-cleaning #40183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the eos-portable-archive sources that were copy-pasted into `CondFormats/Serialization`, the boost implementation detail `fp_traits<T>::value` is used, which is expected to resolve to `fp_traits_non_native` that has the `bits` and `set_bits` attributes, which are used in the code. But depending on the compiler flags, `fp_traits<T>::value` can also resolve to `fp_traits_native`, which doesn't have `bits` and `set_bits`. It only works when `BOOST_MATH_DISABLE_STD_FPCLASSIFY` is set. To make the CMSSW code compile independent of the boost flags, this commit suggests to directly use `fp_traits_non_native` in exactly the same way as it is used inside `fp_traits` in the `boost/math/special_functions/detail/fp_traits.hpp` header file from boost. See also: daldegam/eos-portable-archive#5
- dropping T from templates for plugins and modules (keeping at the moment for structs and datastructures); - simplifing TrackingRecHit2DHeterogeneous; - fixing test in TrackingRecHit2DCUDA_t; - fixing the PixelCPEGeneric error from the tests; - cleaning.
- Reverting template syntax using boht *Phase1 and former module naming - Removing legacy TrackSoAHeterogeneousT - Reverting to default descriptions
- Rolling back to PixelCPEFastESProducer for HLT+RECO compatibility - Cleaning, code formatting - Static analyzer warnings - Sizes for Vertices - Wf fix
…DeepCSVJetTags:probb' for Run 3.
reorganize output module to output initemp file markers early
…wards compatibility
… lowPtElectrons are not PF
swertz
force-pushed
the
matchingCleaning_from-CMSSW_13_0_0_pre1
branch
from
bee64f2 to
cd0cf1b
Compare
cmsbuild
added
alca-pending
analysis-pending
core-pending
daq-pending
db-pending
dqm-pending
geometry-pending
heterogeneous-pending
hlt-pending
l1-pending
operations-pending
pdmv-pending
simulation-pending
tests-pending
upgrade-pending
visualization-pending
xpog-pending
and removed
tests-approved
xpog-approved
labels
|
Pull request #40183 was updated. @rappoccio, @kskovpen, @bbilin, @pmandrik, @ianna, @Martin-Grunewald, @rekovic, @ChrisMisan, @cecilecaillol, @perrotta, @civanch, @yuanchao, @vlimant, @makortel, @ahmad3213, @cmsbuild, @missirol, @fwyzard, @mandrenguyen, @smorovic, @davidlange6, @smuzaffar, @Dr15Jones, @epalencia, @emanueleusai, @mdhildreth, @AdrianoDee, @jfernan2, @syuvivida, @ggovi, @micsucmed, @fabiocos, @francescobrivio, @malbouis, @swertz, @bsunanda, @emeschi, @clacaputo, @alja, @srimanob, @saumyaphor4252, @sunilUIET, @tvami, @rvenditti can you please check and sign again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Fill in a few gaps in the matching between collections in Nano, remove the object cleanmask branches.
PR validation:
Done in #40162
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
Backport of #40162, relevant for a 12_6 nano